From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33703)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZPV8B-0003L0-PP
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 08:27:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZPV87-0003ec-OP
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 08:27:43 -0400
Received: from mailout2.w1.samsung.com ([210.118.77.12]:45125)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZPV87-0003eB-IL
	for qemu-devel@nongnu.org; Wed, 12 Aug 2015 08:27:39 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout2.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NSY00BI5YLY5V50@mailout2.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 12 Aug 2015 13:27:34 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <cover.1439207299.git.p.fedin@samsung.com>
	<921907bc07635dbe258f715015d09c41512447b3.1439207299.git.p.fedin@samsung.com>
	<CAFEAcA9Y7s0ChPnrv48JQxZrG3rHXtck8rHndYznZEMSCigQbw@mail.gmail.com>
In-reply-to: <CAFEAcA9Y7s0ChPnrv48JQxZrG3rHXtck8rHndYznZEMSCigQbw@mail.gmail.com>
Date: Wed, 12 Aug 2015 15:27:32 +0300
Message-id: <017f01d0d4fa$43cf3570$cb6da050$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH v8 3/5] Introduce irqchip
 type	specification for KVM
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, 'Shlomo Pongratz' <shlomopongratz@gmail.com>, 'QEMU Developers' <qemu-devel@nongnu.org>, 'Christoffer Dall' <christoffer.dall@linaro.org>, 'Eric Auger' <eric.auger@linaro.org>

 Hello!

> I still think this is the wrong approach -- see my remarks
> in the previous round of patch review.

 You know... I thought a little bit...
 So far, test =3D true in KVM_CREATE_DEVICE means that we just want to =
know whether this type is supported. No actual actions is done by the =
kernel. Is it correct? If yes, we can just leave this test as it is, =
because if it says that GICv2 is supported by KVM_CREATE_DEVICE, then:
1. We use new API. No KVM_IRQCHIP_CREATE.
2. GICv3 may be supported.

 Therefore, if we do this check, and it succeeds, then we just proceed, =
and later actually try to create GICv3. If it fails for some reason, we =
will see error message anyway. So would it be OK just not to touch =
kvm_arch_irqchip_create() at all?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia