qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu-iotests: restrict 264 to qcow2 only
Date: Mon, 28 Oct 2019 13:08:58 +0100	[thread overview]
Message-ID: <0188acea-2709-b243-22d0-3e1ee2546bb6@redhat.com> (raw)
In-Reply-To: <6284b05a-192b-0a63-6767-145a4a832424@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1061 bytes --]

On 25.10.19 17:38, Eric Blake wrote:
> On 10/25/19 9:50 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 264 is unprepared to run with different formats, for example luks needs
>> handling keys, cloop doesn't support image creation, vpc creates image
>> larger than requested (which breaks "Backup completed: 5242880" in test
>> output).
>>
>> The test is here to check nbd-reconnect feature and we actually don't
>> need it for all formats. Let's restrict it to qcow2 only.
>>
>> Reported-by: Max Reitz <mreitz@redhat.com>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   tests/qemu-iotests/264 | 2 ++
>>   1 file changed, 2 insertions(+)
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> I will queue through my NBD tree; it may miss soft freeze (due to my
> travel schedule for KVM Forum), but is definite 4.2 material, so it will
> be in by rc1.

Hm, well.  I need this patch anyway or my pre-pull-request tests won’t
pass.  So I suppose there is no reason for me not to take it. O:-)

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2019-10-28 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 14:50 [PATCH] qemu-iotests: restrict 264 to qcow2 only Vladimir Sementsov-Ogievskiy
2019-10-25 15:38 ` Eric Blake
2019-10-28 12:08   ` Max Reitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0188acea-2709-b243-22d0-3e1ee2546bb6@redhat.com \
    --to=mreitz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).