From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: "'Peter Maydell <peter.maydell@linaro.org>'"@samsung.com,
'QEMU Developers' <qemu-devel@nongnu.org>,
"'Shannon Zhao <zhaoshenglong@huawei.com>'"@samsung.com
Subject: Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication
Date: Wed, 19 Aug 2015 15:45:34 +0300 [thread overview]
Message-ID: <019901d0da7c$f1636fd0$d42a4f70$@samsung.com> (raw)
In-Reply-To: <CAFEAcA9fdUpbefT=euCFHZY+u4t4ZCX5LfKYEwfJGLsrmUKTXw@mail.gmail.com>
Hello!
> Why bother? This is adding more code than it deletes
I just don't like code duplication, wanted to do this long time ago. Additionally this enables to add support for virtio-mmio to more machines. Actually it could be used not only by ARM with little modifications.
> and is implicitly tying together details of how the these
> two boards are laid out
What exactly do you mean? The only thing assumed by new functions is that
virtio-mmio devices are laid out in a single addresses window, one after another. Base address and irq do not have to be the same everywhere.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
prev parent reply other threads:[~2015-08-19 12:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 11:23 [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication Pavel Fedin
2015-08-19 12:32 ` Peter Maydell
2015-08-19 12:45 ` Pavel Fedin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019901d0da7c$f1636fd0$d42a4f70$@samsung.com' \
--to=p.fedin@samsung.com \
--cc="'Peter Maydell <peter.maydell@linaro.org>'"@samsung.com \
--cc="'Shannon Zhao <zhaoshenglong@huawei.com>'"@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).