From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42691)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZS2kV-0003Qq-B6
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:45:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZS2kQ-0001D2-D1
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:45:47 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:42009)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1ZS2kQ-0001CW-85
	for qemu-devel@nongnu.org; Wed, 19 Aug 2015 08:45:42 -0400
Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244])
	by mailout4.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NTB007ARY3Z5H90@mailout4.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 19 Aug 2015 13:45:35 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <018a01d0da71$7a6f52a0$6f4df7e0$@samsung.com>
	<CAFEAcA9fdUpbefT=euCFHZY+u4t4ZCX5LfKYEwfJGLsrmUKTXw@mail.gmail.com>
In-reply-to: <CAFEAcA9fdUpbefT=euCFHZY+u4t4ZCX5LfKYEwfJGLsrmUKTXw@mail.gmail.com>
Date: Wed, 19 Aug 2015 15:45:34 +0300
Message-id: <019901d0da7c$f1636fd0$d42a4f70$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: quoted-printable
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH] virtio-mmio: Kill code duplication
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: "'Peter Maydell <peter.maydell@linaro.org>'"@samsung.com, 'QEMU Developers' <qemu-devel@nongnu.org>, "'Shannon Zhao <zhaoshenglong@huawei.com>'"@samsung.com

 Hello!

> Why bother? This is adding more code than it deletes

 I just don't like code duplication, wanted to do this long time ago. =
Additionally this enables to add support for virtio-mmio to more =
machines. Actually it could be used not only by ARM with little =
modifications.

> and is implicitly tying together details of how the these
> two boards are laid out

 What exactly do you mean? The only thing assumed by new functions is =
that=20
virtio-mmio devices are laid out in a single addresses window, one after =
another. Base address and irq do not have to be the same everywhere.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia