From: Pavel Fedin <p.fedin@samsung.com>
To: 'Diana Craciun' <diana.craciun@freescale.com>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
'Eric Auger' <eric.auger@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v4 4/5] Initial implementation of vGICv3
Date: Wed, 15 Jul 2015 18:32:14 +0300 [thread overview]
Message-ID: <01b801d0bf13$6d44be90$47ce3bb0$@samsung.com> (raw)
In-Reply-To: <55A6704E.4050500@freescale.com>
Hello!
> Here GICV3_INTERNAL is used, but kvm_arch_gicv3_set_irq relies on
> kvm_arm_gic_set_irq which is using GIC_INTERNAL, so the GICv3 related
> code is using both defines.
The change relies on these definitions being equal. Ok, i agree this is a kind of hack and will
redo this in v5.
> As we do not have yet support for ITS implementation in QEMU the device
> tree for a GICv3 guest will have a msi-parent property in the device
> tree which will point to nothing:
>
> "msi-parent = <0x0>"
Oops, thank you, i forgot about this. Will fix.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-07-15 15:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 7:54 [Qemu-devel] [PATCH v4 0/5] vGICv3 support Pavel Fedin
2015-07-14 7:54 ` [Qemu-devel] [PATCH v4 1/5] Implement GIC-500 base class Pavel Fedin
2015-07-14 7:54 ` [Qemu-devel] [PATCH v4 2/5] Extract some reusable vGIC code Pavel Fedin
2015-07-14 7:54 ` [Qemu-devel] [PATCH v4 3/5] Introduce irqchip type specification for KVM Pavel Fedin
2015-07-14 7:54 ` [Qemu-devel] [PATCH v4 4/5] Initial implementation of vGICv3 Pavel Fedin
2015-07-15 14:38 ` Diana Craciun
2015-07-15 15:32 ` Pavel Fedin [this message]
2015-07-14 7:54 ` [Qemu-devel] [PATCH v4 5/5] Add gicversion option to virt machine Pavel Fedin
2015-07-15 14:44 ` Diana Craciun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01b801d0bf13$6d44be90$47ce3bb0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@freescale.com \
--cc=eric.auger@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).