From: Jason Wang <jasowang@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
qemu devel <qemu-devel@nongnu.org>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>,
bian naimeng <biannm@cn.fujitsu.com>,
"eddie . dong" <eddie.dong@intel.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH V2 2/3] COLO-compare: Optimize compare_common and compare_tcp
Date: Thu, 2 Mar 2017 15:51:54 +0800 [thread overview]
Message-ID: <01b98ebb-feb2-c0f6-62ed-8b3d1712a028@redhat.com> (raw)
In-Reply-To: <64fa3338-3771-4f19-7882-8a028aac87a4@cn.fujitsu.com>
On 2017年02月28日 14:11, Zhang Chen wrote:
>>
>
> OK, How about this?
>
> + /*
> + * Because of ppkt and spkt are both in the same connection,
> + * The ppkt's src ip, dst ip, src port, dst port, ip_proto all are
> + * same with spkt. In addition, IP header's Identification is a
> random
> + * field, we can handle it in IP fragmentation function later.
> + * So we just compare the ip payload here. we ignored all IP header
> + * include other field like TOS,TTL,IP Checksum.
> + */
>
> Thanks
> Zhang Chen
But this does not explain why we can ignore those fields.
Thanks
next prev parent reply other threads:[~2017-03-02 7:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 5:18 [Qemu-devel] [PATCH V2 0/3] COLO-compare: Optimize the code and fix some bug Zhang Chen
2017-02-28 5:18 ` [Qemu-devel] [PATCH V2 1/3] COLO-compare: Rename compare function and remove duplicate codes Zhang Chen
2017-02-28 5:18 ` [Qemu-devel] [PATCH V2 2/3] COLO-compare: Optimize compare_common and compare_tcp Zhang Chen
2017-02-28 5:47 ` Jason Wang
2017-02-28 6:11 ` Zhang Chen
2017-03-02 7:51 ` Jason Wang [this message]
2017-03-02 8:15 ` Zhang Chen
2017-03-02 9:35 ` Jason Wang
2017-02-28 5:18 ` [Qemu-devel] [PATCH V2 3/3] COLO-compare: Fix icmp and udp compare different packet always dump bug Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b98ebb-feb2-c0f6-62ed-8b3d1712a028@redhat.com \
--to=jasowang@redhat.com \
--cc=biannm@cn.fujitsu.com \
--cc=eddie.dong@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).