From: Thomas Huth <huth@tuxfamily.org>
To: "Bug 1735384" <1735384@bugs.launchpad.net>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Cc: Richard Henderson <rth@twiddle.net>, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [Bug 1735384] Re: OpenJDK JVM segfaults on qemu-sh4 (regression)
Date: Sun, 3 Dec 2017 16:52:24 +0100 [thread overview]
Message-ID: <01c38497-beda-2450-026d-38876cfda2cc@tuxfamily.org> (raw)
In-Reply-To: <177a2c67-932a-8842-fc71-229373bc28aa@physik.fu-berlin.de>
On 01.12.2017 00:25, John Paul Adrian Glaubitz wrote:
> The offending commit is:
>
> d25f2a72272b9ffe0d06710d6217d1169bc2cc7d is the first bad commit
> commit d25f2a72272b9ffe0d06710d6217d1169bc2cc7d
> Author: Alex Bennée <alex.bennee@linaro.org>
> Date: Mon Nov 13 13:55:27 2017 +0000
>
> accel/tcg/translate-all: expand cpu_restore_state addr check
>
> We are still seeing signals during translation time when we walk over
> a page protection boundary. This expands the check to ensure the host
> PC is inside the code generation buffer. The original suggestion was
> to check versus tcg_ctx.code_gen_ptr but as we now segment the
> translation buffer we have to settle for just a general check for
> being inside.
>
> I've also fixed up the declaration to make it clear it can deal with
> invalid addresses. A later patch will fix up the call sites.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Message-id: 20171108153245.20740-2-alex.bennee@linaro.org
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Tested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> :040000 040000 da50c4c43089d3ee7d1e9ad50d3c9036114e5f11 cd6a0dcaa1d284fe5439f6f3b61547d4b0662768 M accel
> :040000 040000 c294a7c102d27295f8d81cc06b5d4d17357440ad 5a1268b7634f69f0806f22161ec7d6a1a26c8812 M include
>
> Reverting the commit resolves the issue.
>
Alex, any ideas what might be wrong here?
Thomas
next prev parent reply other threads:[~2017-12-03 15:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 10:19 [Qemu-devel] [Bug 1735384] [NEW] OpenJDK JVM segfaults on qemu-sh4 (regression) John Paul Adrian Glaubitz
2017-11-30 12:19 ` [Qemu-devel] [Bug 1735384] " Peter Maydell
2017-11-30 12:39 ` John Paul Adrian Glaubitz
2017-11-30 23:25 ` John Paul Adrian Glaubitz
2017-12-03 15:52 ` Thomas Huth [this message]
2017-12-04 9:29 ` Alex Bennée
2017-12-04 11:53 ` John Paul Adrian Glaubitz
2017-12-04 13:39 ` Alex Bennée
2017-12-05 15:02 ` [Qemu-devel] [Bug 1735384] [NEW] " Alex Bennée
2017-12-05 15:11 ` John Paul Adrian Glaubitz
2017-12-06 9:30 ` [Qemu-devel] [RFC PATCH] target/sh4/translate.c: fix TCG leak during gusa sequence Alex Bennée
2017-12-06 9:45 ` [Qemu-devel] [Bug 1735384] " John Paul Adrian Glaubitz
2017-12-06 10:52 ` Alex Bennée
2017-12-06 11:37 ` John Paul Adrian Glaubitz
2017-12-06 10:22 ` John Paul Adrian Glaubitz
2017-12-06 14:15 ` [Qemu-devel] " Richard Henderson
2017-12-06 22:33 ` Aurelien Jarno
2018-12-14 12:33 ` [Qemu-devel] [Bug 1735384] Re: OpenJDK JVM segfaults on qemu-sh4 (regression) John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c38497-beda-2450-026d-38876cfda2cc@tuxfamily.org \
--to=huth@tuxfamily.org \
--cc=1735384@bugs.launchpad.net \
--cc=alex.bennee@linaro.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).