From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KvadA-00016x-AG
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 12:44:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Kvad7-00016l-PI
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 12:44:18 -0400
Received: from [199.232.76.173] (port=43723 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Kvad7-00016i-Ha
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 12:44:17 -0400
Received: from ragnell.blacknight.ie ([81.17.252.110]:56058)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <qemu@emutex.com>) id 1Kvad7-0005CJ-IG
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 12:44:17 -0400
Received: from [91.123.224.1] (helo=marklaptop)
	by ragnell.blacknight.ie with esmtp (Exim 4.60)
	(envelope-from <qemu@emutex.com>) id 1Kvacg-000681-Vm
	for qemu-devel@nongnu.org; Thu, 30 Oct 2008 16:43:51 +0000
From: "Mark Burkley" <qemu@emutex.com>
References: <E1KqsdV-0000r9-5B@monty-python.gnu.org>	<11d301c93090$7e06d290$7a1477b0$@com>	<010f01c93810$47ccb500$d7661f00$@com>
	<4905C997.5060801@codemonkey.ws>
In-Reply-To: <4905C997.5060801@codemonkey.ws>
Subject: RE: [Qemu-devel] Preliminary patch to implement ehci
Date: Thu, 30 Oct 2008 16:43:49 -0000
Message-ID: <01d701c93aae$af7487a0$0e5d96e0$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: en-ie
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi Anthony,

I have ehci built against trunk now but I am seeing an issue with a memory
key I am using for testing.  ioctl returns EPIPE (which I would have thought
was a STALL) to an asynchronous IN completion in usb-linux.c but then this
is returned as USB_RET_NAK to EHCI which confuses my WinXP target because
the transfer is then never completed.

Can I just check that it was intentional to return NAK for EPIPE returns in
asynchronous completions?  If so, then I will try to detect the stall in my
implementation and treat differently to a NAK.  It's just that if I modify
usb-linux.c to return USB_RET_STALL on -EPIPE then it works fine.

Thanks,

Mark


-----Original Message-----
From: qemu-devel-bounces+qemu=emutex.com@nongnu.org
[mailto:qemu-devel-bounces+qemu=emutex.com@nongnu.org] On Behalf Of Anthony
Liguori
Sent: 27 October 2008 14:01
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Preliminary patch to implement ehci

Mark Burkley wrote:
> Hi folks,
>
> Just checking, did anyone get a chance to look at this?
>
> Any suggestions for next steps?  Should I post a patch against trunk?
>   

Submitting the patch against 0.9.1 is a non-starter.  0.9.1 is at least 
a year old and the USB code has been majorly refactored.  If you want 
people to review it, it has to be against trunk.

Also make sure that you include a [PATCH] in your subject.  Otherwise, 
it's easily missed on the list.

Regards,

Anthony Liguori

> Thanks,
>
> Mark
>