From: gaosong <gaosong@loongson.cn>
To: WANG Xuerui <i.qemu@xen0n.name>
Cc: alex.bennee@linaro.org, f4bug@amsat.org,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
laurent@vivier.eu
Subject: Re: [PATCH] linux-user: move target_signal.h generic definitions to generic/signal.h
Date: Thu, 25 Nov 2021 20:52:46 +0800 [thread overview]
Message-ID: <01e80f0e-035d-8352-b225-d6dce9d943d0@loongson.cn> (raw)
In-Reply-To: <f53f4fef-2ed9-3e9f-3104-ac4780819115@xen0n.name>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
Hi,
On 2021/11/25 下午6:08, WANG Xuerui wrote:
>> +
>> +#define TARGET_MINSIGSTKSZ 2048
> While all the architectures you de-duplicated here have
> TARGET_MINSIGSTACKSZ as 2048, some others specify a different value
> (mostly 4096, e.g. alpha), as can be seen in your next patch (which
> should belong to this series, btw).
Surely I 'll add a patch to delete TARGET_SIGSTKSZ.
> Do you mean to change semantics
> here? Or you might have to allow arches to override this value.
>
>
mips64, sparc, alpha, mips, hppa, their signal definitions are defined
in /linux-user/XXX/target_signal.h,
but their target_signal.h don't include generic/signal.h. they don't
use generic/signal.h at all.
It's hard to move their some generic definitions to generic/signal.h,
because their definitions are too defferent with generic.
Thanks
Song Gao
[-- Attachment #2: Type: text/html, Size: 1593 bytes --]
prev parent reply other threads:[~2021-11-25 12:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 8:55 [PATCH] linux-user: move target_signal.h generic definitions to generic/signal.h Song Gao
2021-11-25 9:49 ` Laurent Vivier
2021-11-25 10:08 ` WANG Xuerui
2021-11-25 12:52 ` gaosong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01e80f0e-035d-8352-b225-d6dce9d943d0@loongson.cn \
--to=gaosong@loongson.cn \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=i.qemu@xen0n.name \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).