From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K64wC-0007wz-U5
	for qemu-devel@nongnu.org; Tue, 10 Jun 2008 10:35:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K64w9-0007vm-UQ
	for qemu-devel@nongnu.org; Tue, 10 Jun 2008 10:35:02 -0400
Received: from [199.232.76.173] (port=33290 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K64w8-0007vL-V8
	for qemu-devel@nongnu.org; Tue, 10 Jun 2008 10:35:01 -0400
Received: from mail.gmx.net ([213.165.64.20]:53185)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1K64w8-0002fk-GA
	for qemu-devel@nongnu.org; Tue, 10 Jun 2008 10:35:00 -0400
Message-ID: <01f001c8cb07$28c41d90$0201a8c0@zeug>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <Pine.LNX.4.64.0806092312040.18515@anvil.nuitari.net>
	<019c01c8cafe$d64f6310$0201a8c0@zeug>
Date: Tue, 10 Jun 2008 16:33:46 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Problem(s) with encrypted images
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

>> 2. When I start qemu, it just hangs there waiting for (assumingly) the 
>> password of the encrypted image. However I cannot find the place where the 
>> prompt actually is.
> 
> qemu_key_check in vl.c does use monitor_readline, so you should see a "Password:"
> prompt in the monitor window (press ctrl-alt-2 to get there).
 
The initialization order seems to be wrong in main() (vl.c):

    for(i = 0; i < nb_drives_opt; i++)
        if (drive_init(&drives_opt[i], snapshot, machine) == -1)
            exit(1);
    ...
    *_display_init();
    ...
    monitor_init();

drive_init() got
...
if (bdrv_open2(bdrv, file, bdrv_flags, drv) < 0 || qemu_key_check(bdrv, file)) {

and qemu_key_check depends on the monitor:

    term_printf("%s is encrypted.\n", name);
    for(i = 0; i < 3; i++) {
        monitor_readline("Password: ", 1, password, sizeof(password));

- Sebastian