From: Richard Henderson <richard.henderson@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 01/17] crypto: Move QCryptoCipher typedef to qemu/typedefs.h
Date: Mon, 17 Aug 2020 13:38:56 -0700 [thread overview]
Message-ID: <01f1a99c-9983-9b92-b91d-bd117055cf21@linaro.org> (raw)
In-Reply-To: <20200817164801.GK4775@redhat.com>
On 8/17/20 9:48 AM, Daniel P. Berrangé wrote:
> On Wed, Aug 12, 2020 at 08:25:21PM -0700, Richard Henderson wrote:
>> This allows header files to declare pointers without pulling
>> in the entire crypto subsystem.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> include/crypto/cipher.h | 2 --
>> include/qemu/typedefs.h | 1 +
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> I'm not in favour of this change or the next. Using #include "cipher.h"
> is not a burden on the users of the crypto code. Moving typedefs away
> from the associated struct is a step backwards IMHO.
Consider if you put a pointer to QCryptoCipher in a relatively generic header
file (e.g. "target/foo/cpu.h"), restricting "cipher.h" to a portion of the
implementation (e.g. target/foo/helper_crypto.c).
This sort of thing is exactly why "qemu/typedefs.h" exists.
r~
next prev parent reply other threads:[~2020-08-17 20:39 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 3:25 [PATCH 00/17] crypto/cipher: Class hierarchy cleanups Richard Henderson
2020-08-13 3:25 ` [PATCH 01/17] crypto: Move QCryptoCipher typedef to qemu/typedefs.h Richard Henderson
2020-08-13 7:59 ` Philippe Mathieu-Daudé
2020-08-17 16:48 ` Daniel P. Berrangé
2020-08-17 20:38 ` Richard Henderson [this message]
2020-08-17 20:42 ` Richard Henderson
2020-08-17 20:50 ` Richard Henderson
2020-08-28 13:28 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 02/17] crypto: Move QCryptoCipherDriver " Richard Henderson
2020-08-13 7:59 ` Philippe Mathieu-Daudé
2020-08-13 3:25 ` [PATCH 03/17] crypto: Assume blocksize is a power of 2 Richard Henderson
2020-08-17 16:51 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 04/17] crypto: Rename cipher include files to .inc.c Richard Henderson
2020-08-13 8:00 ` Philippe Mathieu-Daudé
2020-08-17 16:52 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 05/17] crypto: Remove redundant includes Richard Henderson
2020-08-13 8:01 ` Philippe Mathieu-Daudé
2020-08-17 16:50 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 06/17] crypto/nettle: Fix xts_encrypt arguments Richard Henderson
2020-08-17 16:53 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 07/17] crypto: Use the correct const type for driver Richard Henderson
2020-08-13 8:02 ` Philippe Mathieu-Daudé
2020-08-17 16:53 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 08/17] crypto: Allocate QCryptoCipher with the subclass Richard Henderson
2020-08-17 16:55 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 09/17] crypto: Move cipher->driver init to qcrypto_*_cipher_ctx_new Richard Henderson
2020-08-17 16:56 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 10/17] crypto: Constify cipher data tables Richard Henderson
2020-08-13 8:03 ` Philippe Mathieu-Daudé
2020-08-17 16:56 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 11/17] crypto/builtin: Remove odd-sized AES block handling Richard Henderson
2020-08-17 16:57 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 12/17] crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt Richard Henderson
2020-08-13 8:05 ` Philippe Mathieu-Daudé
2020-08-17 17:00 ` [PATCH 12/17] crypto/builtin: Merge qcrypto_cipher_aes_{ecb,xts}_{en,de}crypt Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 13/17] crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c Richard Henderson
2020-08-13 8:11 ` Philippe Mathieu-Daudé
2020-08-17 17:01 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc Richard Henderson
2020-08-17 17:02 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subclasses Richard Henderson
2020-08-28 13:44 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 16/17] crypto/nettle: Split QCryptoCipherNettle " Richard Henderson
2020-08-28 13:46 ` Daniel P. Berrangé
2020-08-13 3:25 ` [PATCH 17/17] crypto/gcrypt: Split QCryptoCipherGcrypt " Richard Henderson
2020-08-28 13:52 ` Daniel P. Berrangé
2020-08-13 8:54 ` [PATCH 00/17] crypto/cipher: Class hierarchy cleanups Philippe Mathieu-Daudé
2020-08-13 10:48 ` no-reply
2020-08-13 11:11 ` no-reply
2020-08-17 16:45 ` Daniel P. Berrangé
2020-08-17 17:09 ` Daniel P. Berrangé
2020-08-17 20:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f1a99c-9983-9b92-b91d-bd117055cf21@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).