From: Jianjun Duan <duanj@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org,
dgilbert@redhat.com, mst@redhat.com, quintela@redhat.com,
mark.cave-ayland@ilande.co.uk, mdroth@linux.vnet.ibm.com,
mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com,
qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com,
dmitry@daynix.com, rth@twiddle.net, leon.alrae@imgtec.com,
aurelien@aurel32.net, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v7 2/3] migration: migrate QTAILQ
Date: Thu, 27 Oct 2016 09:50:58 -0700 [thread overview]
Message-ID: <02103407-1f60-4a56-f34d-bc2541c3ca78@linux.vnet.ibm.com> (raw)
In-Reply-To: <0dd47cb7-d83f-3f11-feab-e91be817c973@redhat.com>
On 10/27/2016 05:01 AM, Paolo Bonzini wrote:
>
>
> On 26/10/2016 18:58, Jianjun Duan wrote:
>>>>
>>>> Seems you partially adopted Paolo's suggestion for improving the
>>>> macros. Is there a particular reason why you did not follow it more
>>>> closely? I find the solution with field_at_offset(base, offset, type)
>>>> more readable than with RAW_FIELD(base, offset).
>>>>
>> field_at_offset is too general. We only use (void **) and (void ***)
>> here.
>
> Uhm, field_at_offset is exactly the same as RAW_FIELD. :)
>
Yes. It all comes down to offset and cast.
Thanks,
Jianjun
> Paolo
>
next prev parent reply other threads:[~2016-10-27 16:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 22:52 [Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ Jianjun Duan
2016-10-21 22:52 ` [Qemu-devel] [QEMU PATCH v7 1/3] migration: extend VMStateInfo Jianjun Duan
2016-10-21 22:52 ` [Qemu-devel] [QEMU PATCH v7 2/3] migration: migrate QTAILQ Jianjun Duan
2016-10-26 12:29 ` Halil Pasic
2016-10-26 16:58 ` [Qemu-devel] [Qemu-ppc] " Jianjun Duan
2016-10-27 12:01 ` Paolo Bonzini
2016-10-27 16:50 ` Jianjun Duan [this message]
2016-10-21 22:52 ` [Qemu-devel] [QEMU PATCH v7 3/3] tests/migration: Add test for QTAILQ migration Jianjun Duan
2016-10-21 23:19 ` [Qemu-devel] [QEMU PATCH v7 0/3] migration: migrate QTAILQ no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02103407-1f60-4a56-f34d-bc2541c3ca78@linux.vnet.ibm.com \
--to=duanj@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=dmitry@daynix.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=veroniabahaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).