From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v2] configure: Relax check for libseccomp
Date: Fri, 5 Apr 2019 10:50:28 +0200 [thread overview]
Message-ID: <02191499-2d1c-18a1-346d-4afda800d5ee@redhat.com> (raw)
In-Reply-To: <20190404183923.GA22347@ls3530.dellerweb.de>
On 4/4/19 8:39 PM, Helge Deller wrote:
> All major distributions do support libseccomp version >= 2.3.0, so there
> is no need to special-case on various architectures any longer.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> diff --git a/configure b/configure
> index 1c563a7027..8fe4fc84d8 100755
> --- a/configure
> +++ b/configure
> @@ -2377,36 +2369,16 @@ fi
> ##########################################
> # libseccomp check
>
> -libseccomp_minver="2.2.0"
> if test "$seccomp" != "no" ; then
> - case "$cpu" in
> - i386|x86_64|mips)
> - ;;
> - arm|aarch64)
> - libseccomp_minver="2.2.3"
> - ;;
> - ppc|ppc64|s390x)
> - libseccomp_minver="2.3.0"
> - ;;
> - *)
> - libseccomp_minver=""
> - ;;
> - esac
> -
> - if test "$libseccomp_minver" != "" &&
> - $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
> + libseccomp_minver="2.3.0"
> + if $pkg_config --atleast-version=$libseccomp_minver libseccomp ; then
> seccomp_cflags="$($pkg_config --cflags libseccomp)"
> seccomp_libs="$($pkg_config --libs libseccomp)"
> seccomp="yes"
> else
> if test "$seccomp" = "yes" ; then
> - if test "$libseccomp_minver" != "" ; then
> - feature_not_found "libseccomp" \
> - "Install libseccomp devel >= $libseccomp_minver"
> - else
> - feature_not_found "libseccomp" \
> - "libseccomp is not supported for host cpu $cpu"
> - fi
> + feature_not_found "libseccomp" \
> + "Install libseccomp devel >= $libseccomp_minver"
> fi
> seccomp="no"
> fi
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-04-05 9:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:49 [Qemu-devel] [PATCH] configure: Relax check for libseccomp Helge Deller
2019-04-03 15:16 ` Peter Maydell
2019-04-03 15:17 ` Peter Maydell
2019-04-03 15:55 ` Helge Deller
2019-04-03 21:04 ` Eduardo Habkost
2019-04-04 1:44 ` Peter Maydell
2019-04-03 16:17 ` Daniel P. Berrangé
2019-04-04 1:53 ` Peter Maydell
2019-04-04 6:59 ` Thomas Huth
2019-04-04 8:56 ` Daniel P. Berrangé
2019-04-04 18:39 ` [Qemu-devel] [PATCH v2] " Helge Deller
2019-04-04 20:01 ` Thomas Huth
2019-04-05 9:01 ` Eduardo Otubo
2019-04-05 9:01 ` Eduardo Otubo
2019-04-05 7:34 ` Daniel P. Berrangé
2019-04-05 7:34 ` Daniel P. Berrangé
2019-04-05 8:50 ` Philippe Mathieu-Daudé [this message]
2019-04-05 8:50 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02191499-2d1c-18a1-346d-4afda800d5ee@redhat.com \
--to=philmd@redhat.com \
--cc=deller@gmx.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).