From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: Mads Ynddal <mads@ynddal.dk>,
alex.bennee@linaro.org, Stefan Hajnoczi <stefanha@redhat.com>,
richard.henderson@linaro.org, manos.pitsidianakis@linaro.org,
philmd@linaro.org
Subject: Re: [PATCH] trace/control-target: cleanup headers and make compilation unit common
Date: Mon, 10 Mar 2025 10:17:53 -0700 [thread overview]
Message-ID: <0227dd71-5c01-4bde-acf1-8c5c39b46d1e@linaro.org> (raw)
In-Reply-To: <20250305050716.3460989-1-pierrick.bouvier@linaro.org>
On 3/4/25 21:07, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> trace/control-target.c | 2 --
> trace/meson.build | 4 +---
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/trace/control-target.c b/trace/control-target.c
> index d58e84f6dd8..57ceac21084 100644
> --- a/trace/control-target.c
> +++ b/trace/control-target.c
> @@ -8,8 +8,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/lockable.h"
> -#include "cpu.h"
> #include "trace/control.h"
>
>
> diff --git a/trace/meson.build b/trace/meson.build
> index c3412dc0ba5..3df45493555 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -1,6 +1,4 @@
> -system_ss.add(files('trace-hmp-cmds.c'))
> -
> -specific_ss.add(files('control-target.c'))
> +system_ss.add(files('control-target.c', 'trace-hmp-cmds.c'))
>
> trace_events_files = []
> foreach item : [ '.' ] + trace_events_subdirs + qapi_trace_events
Hi folks,
gentle ping on this trivial change.
Regards,
Pierrick
next prev parent reply other threads:[~2025-03-10 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 5:07 [PATCH] trace/control-target: cleanup headers and make compilation unit common Pierrick Bouvier
2025-03-10 17:17 ` Pierrick Bouvier [this message]
2025-03-10 17:53 ` Richard Henderson
2025-03-10 17:55 ` Alex Bennée
2025-03-11 2:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0227dd71-5c01-4bde-acf1-8c5c39b46d1e@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=mads@ynddal.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).