From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Cc: qemu-devel@nongnu.org,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: Re: [PATCH v1 1/2] target/ppc: PMU do not clear MMCR0[FCECE] on performance monitor alert
Date: Mon, 5 Jun 2023 08:10:26 -0300 [thread overview]
Message-ID: <0237ea14-67c9-b4bf-e656-8337487df427@gmail.com> (raw)
In-Reply-To: <20230530134313.387252-1-npiggin@gmail.com>
On 5/30/23 10:43, Nicholas Piggin wrote:
> FCECE does not get cleared according to the ISA v3.1B.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
And queued.
Daniel
> target/ppc/power8-pmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c
> index c4c331c6b5..af065115f2 100644
> --- a/target/ppc/power8-pmu.c
> +++ b/target/ppc/power8-pmu.c
> @@ -289,7 +289,6 @@ static void fire_PMC_interrupt(PowerPCCPU *cpu)
> pmu_update_cycles(env);
>
> if (env->spr[SPR_POWER_MMCR0] & MMCR0_FCECE) {
> - env->spr[SPR_POWER_MMCR0] &= ~MMCR0_FCECE;
> env->spr[SPR_POWER_MMCR0] |= MMCR0_FC;
>
> /* Changing MMCR0_FC requires summaries and hflags update */
prev parent reply other threads:[~2023-06-05 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 13:43 [PATCH v1 1/2] target/ppc: PMU do not clear MMCR0[FCECE] on performance monitor alert Nicholas Piggin
2023-05-30 13:43 ` [PATCH v1 2/2] target/ppc: PMU implement PERFM interrupts Nicholas Piggin
2023-06-05 11:10 ` Daniel Henrique Barboza
2023-06-05 11:10 ` Daniel Henrique Barboza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0237ea14-67c9-b4bf-e656-8337487df427@gmail.com \
--to=danielhb413@gmail.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=dbarboza@ventanamicro.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).