From: Richard Henderson <richard.henderson@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-stable@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 02/13] target/arm: Fix SQDMULH (by element) with Q=0
Date: Tue, 2 Jul 2024 07:37:37 -0700 [thread overview]
Message-ID: <02506c92-df4e-4616-9fd7-02e9d2a204a4@linaro.org> (raw)
In-Reply-To: <f65e6448-cfd2-425c-853a-5a4ae5cf2a8c@tls.msk.ru>
On 7/1/24 23:48, Michael Tokarev wrote:
> 25.06.2024 21:35, Richard Henderson wrote:
>> The inner loop, bounded by eltspersegment, must not be
>> larger than the outer loop, bounded by elements.
>>
>> Cc: qemu-stable@nongnu.org
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/arm/tcg/vec_helper.c | 24 ++++++++++++++++--------
>> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> If my understanding is correct, this one
>
> Fixes: f80701cb44d3 ("target/arm: Convert SQDMULH, SQRDMULH to decodetree")
>
> and before this commit, there was no issue.
>
> Is my understanding correct?
Yes. So, not as old a bug as I thought.
r~
next prev parent reply other threads:[~2024-07-02 14:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 18:35 [PATCH v2 00/13] target/arm: AdvSIMD conversion, part 2 Richard Henderson
2024-06-25 18:35 ` [PATCH v2 01/13] target/arm: Fix VCMLA Dd, Dn, Dm[idx] Richard Henderson
2024-06-25 18:35 ` [PATCH v2 02/13] target/arm: Fix SQDMULH (by element) with Q=0 Richard Henderson
2024-07-02 6:48 ` Michael Tokarev
2024-07-02 14:37 ` Richard Henderson [this message]
2024-06-25 18:35 ` [PATCH v2 03/13] target/arm: Fix FJCVTZS vs flush-to-zero Richard Henderson
2024-06-25 18:35 ` [PATCH v2 04/13] target/arm: Convert SQRDMLAH, SQRDMLSH to decodetree Richard Henderson
2024-06-25 18:35 ` [PATCH v2 05/13] target/arm: Convert SDOT, UDOT " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 06/13] target/arm: Convert SUDOT, USDOT " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 07/13] target/arm: Convert BFDOT " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 08/13] target/arm: Convert BFMLALB, BFMLALT " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 09/13] target/arm: Convert BFMMLA, SMMLA, UMMLA, USMMLA " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 10/13] target/arm: Add data argument to do_fp3_vector Richard Henderson
2024-06-25 18:35 ` [PATCH v2 11/13] target/arm: Convert FCADD to decodetree Richard Henderson
2024-06-25 18:35 ` [PATCH v2 12/13] target/arm: Convert FCMLA " Richard Henderson
2024-06-25 18:35 ` [PATCH v2 13/13] target/arm: Delete dead code from disas_simd_indexed Richard Henderson
2024-06-28 14:40 ` [PATCH v2 00/13] target/arm: AdvSIMD conversion, part 2 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02506c92-df4e-4616-9fd7-02e9d2a204a4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).