Re: [PATCH] ui/pixman: Fix crash in qemu_pixman_shareable_free()

[Bernhard Beschow <shentey@gmail.com>]

Am 20. Oktober 2025 12:32:33 UTC schrieb Markus Armbruster <armbru@redhat.com>:
>Bernhard Beschow <shentey@gmail.com> writes:
>
>> Am 13. Oktober 2025 11:21:02 UTC schrieb Markus Armbruster <armbru@redhat.com>:
>>>Reported-by: Bernhard Beschow <shentey@gmail.com>
>>>Fixes: b296b29d3414 (ui/pixman: Consistent error handling in qemu_pixman_shareable_free())
>>>Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>>---
>>> ui/qemu-pixman.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>>diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
>>>index e46c6232cf..aea09755b9 100644
>>>--- a/ui/qemu-pixman.c
>>>+++ b/ui/qemu-pixman.c
>>>@@ -291,7 +291,9 @@ qemu_pixman_shareable_free(qemu_pixman_shareable handle,
>>>     Error *err = NULL;
>>> 
>>>     qemu_win32_map_free(ptr, handle, &err);
>>>-    error_report_err(err);
>>>+    if (err) {
>>>+        error_report_err(err);
>>>+    }
>>> #else
>>>     qemu_memfd_free(ptr, size, handle);
>>> #endif
>>
>> Thanks for the quick fix, Markus! The patch is reviewed and I've been testing it for a week. Who is going to merge it?
>
>I can do it.
>
>You provided
>
>    Tested-by: Bernhard Beschow
>    Reviewed-by: Bernhard Beschow
>
>without an e-mail address.  Intentional?

Oh, that wasn't intentional.

> If not, should I use <shentey@gmail.com>?

Yes, please.

Best regards,
Bernhard