From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6270C87FD2 for ; Fri, 1 Aug 2025 01:42:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhemO-0004WS-Lk; Thu, 31 Jul 2025 21:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhekp-0001lX-TD for qemu-devel@nongnu.org; Thu, 31 Jul 2025 21:40:16 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhekn-00018c-Lf for qemu-devel@nongnu.org; Thu, 31 Jul 2025 21:40:15 -0400 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-b26f7d2c1f1so1152784a12.0 for ; Thu, 31 Jul 2025 18:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754012412; x=1754617212; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ye5hpRNxeghqWQrxXm1r6vsgWr11gO5dChXwYTAC8gw=; b=gjdtrYtEs3AASDMnNZKkrIkRSpHhfY9eKmphHykENUsLW6f1InMQ1O226mgId7+/r7 78a4vglJMnbKgoZk/3c2khi5xN2KjEb1JTeLzVIACmq2TXBrON1iWmxLsAsTXJiyJL4N Lbvr8t15wu2qY2996bqtQAtPuPmGGMkdYe1PvrAKnNO3/Qb1RWm3+MKkFk957LZKxfEY QxqhxybR7dzDcYANVhom+Tp5Nje072xXsLYZx6a5aLBpmEaShE6htngEORC86pLVHUK9 1ioPbZwZWKXizluJWqpHCvg5nuTKN4ds8sKcZQqQFbBMUQaJ+DlVAYGsWrtM3sjRTvVZ mxRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754012412; x=1754617212; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ye5hpRNxeghqWQrxXm1r6vsgWr11gO5dChXwYTAC8gw=; b=Sd3+mNWbITdm4qIGKqYD+i2EwfxFO9lZHjGwf7bZ2+ruBWaLtEQtN3op59AhBxtQlk ObGOwMpSNaZeg/k0gRlB+lhygQIbumZ7rt+6bnlsEjM35XVlg+2hTihiLvsJIAAiISxO U/8GIUjItc82EAReITqICjq8AnM8FhWCC/RnTiSX0S5T8kSi4PFTDNsWFq2Jr4u2EGyn gUQon74XbTVMU3jOA/Q4FVgbfXi/Wx99bSvGURh2r6eZBg8aZqOAjbQwIjk9meKAbIDU dlPIv73NO2BesiTtRvDkYZ4h5RTAW4bvjNcW3tmoOC+DTr6a7ipLkryjIkCmmqoy7TLR a+4w== X-Forwarded-Encrypted: i=1; AJvYcCW+ebuJSSPYiPbqIl0FhSes/ZzfTjm/CvJr1sC1AqwB8/7wHeOj8FW9oyl+F0b+PQasDyC1kTn6SqUa@nongnu.org X-Gm-Message-State: AOJu0YxjJl0mgMD7YsG96q5+cMT1XJsxdN3gkD4C37O0rzcyICmgMflg eQ5IUf3DIHuFNGDxFqk3GxmxfUgyObfvs+VlQf2iF3nZcKkB/p+sq1Zl3/TNrsH3nyI= X-Gm-Gg: ASbGncv1+aUEi+itx1y2UZakptaX/TkaMtzYwPWL1KH18OoXn6sMkFT54C4fvj4V9YO Ye3TLxnHMkYYJUxiITd2sGMm/zpyeOe1EFZODQhKlZ/tU1xxn7/RkGQ4zvFM6eWT7TltjJn208c 67nESJVRj67T31L0KyWrf20cWvHCwrN3haNz39Pdh7ap2pqOYOiRF0d+2K6K3yHfksz/XKQ7waE Too7EH5bzL0Dm2tsVnOINS6yUk5O+2+ui6fmz6CyIZ4LWahoQMsHNa4sMugR5F5fB0rTJwi4BE3 NOHN4btsxwQCq1QpTOzyJTJQE7+qjoa5R4OeqSArv3IRPakpF5wye+eD2ClFb/cNax64Ac393Ws jjToRfg+Fa2Wng/6vI88VyDG/AVWw/CB52LjDiSOEJhQCIA== X-Google-Smtp-Source: AGHT+IHdelnKGLrIEmWoUUNaZIsBmvi4pgxb8er7ETiIwl0K4lk+RLx0UzL9m/pNrm9mDn3Nrq5+IA== X-Received: by 2002:a05:6a20:7346:b0:23d:ac50:333e with SMTP id adf61e73a8af0-23de8226dfdmr1273624637.43.1754012412007; Thu, 31 Jul 2025 18:40:12 -0700 (PDT) Received: from [192.168.1.87] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bcce8f9b3sm2663859b3a.38.2025.07.31.18.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 18:40:11 -0700 (PDT) Message-ID: <02748c9e-38f0-4b2e-a7d0-c697cf860e67@linaro.org> Date: Thu, 31 Jul 2025 18:40:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] semihosting/arm-compat-semi: replace target_ulong with uint64_t Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=C3=A9e?= , Weiwei Li , philmd@linaro.org, Liu Zhiwei , Palmer Dabbelt , qemu-riscv@nongnu.org, Alistair Francis References: <20250730220621.1142496-1-pierrick.bouvier@linaro.org> <20250730220621.1142496-8-pierrick.bouvier@linaro.org> <311fb2d2-b8b2-4b1d-aea6-429fe55f8217@linaro.org> From: Pierrick Bouvier In-Reply-To: <311fb2d2-b8b2-4b1d-aea6-429fe55f8217@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/31/25 4:33 PM, Richard Henderson wrote: > On 7/31/25 08:06, Pierrick Bouvier wrote: >> Signed-off-by: Pierrick Bouvier >> --- >> semihosting/arm-compat-semi.c | 24 ++++++++++++------------ >> 1 file changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c >> index e5a665d604b..e3b520631b3 100644 >> --- a/semihosting/arm-compat-semi.c >> +++ b/semihosting/arm-compat-semi.c >> @@ -123,7 +123,7 @@ GuestFD console_out_gf; >> */ >> >> typedef struct LayoutInfo { >> - target_ulong rambase; >> + uint64_t rambase; > > vaddr. > > >> @@ -300,9 +300,9 @@ static void common_semi_seek_cb(CPUState *cs, uint64_t ret, int err) >> * is defined by GDB's remote protocol and is not target-specific.) >> * We put this on the guest's stack just below SP. >> */ >> -static target_ulong common_semi_flen_buf(CPUState *cs) >> +static uint64_t common_semi_flen_buf(CPUState *cs) >> { >> - target_ulong sp = common_semi_stack_bottom(cs); >> + uint64_t sp = common_semi_stack_bottom(cs); >> return sp - 64; >> } >> > > vaddr. > Will change to it, thanks. > Otherwise, > Reviewed-by: Richard Henderson > > r~