From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JlVSj-000268-5R
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 16:39:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JlVSg-000234-T3
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 16:39:36 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JlVSg-00022h-Jb
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 16:39:34 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1JlVSg-0003CY-Aj
	for qemu-devel@nongnu.org; Mon, 14 Apr 2008 16:39:34 -0400
Message-ID: <027a01c89e6f$a103d300$0201a8c0@zeug>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <BAY110-DAV84E68554126EF6FD13300B9E90@phx.gbl>
Date: Mon, 14 Apr 2008 22:38:32 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: -vga switch
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> I'm just throwing this out here to see if anyone else is interested in this 
> idea: There seems to be different arguments to set up a display adaptor for a 
> virtual machine.  Why not set it up so that you can have a central way of 
> doing it, such as a -vga argument.  For instance, -vga vmware would use the 
> vmware VGA adaptor, and -vga standard would use the standard VGA adaptor, and 
> so on.

You mean something like this?

--- vl.c.orig Mon Apr 14 19:20:56 2008
+++ vl.c Mon Apr 14 20:19:24 2008
@@ -7835,6 +7835,7 @@ enum {
     QEMU_OPTION_old_param,
     QEMU_OPTION_clock,
     QEMU_OPTION_startdate,
+    QEMU_OPTION_vga,
 };
 
 typedef struct QEMUOption {
@@ -7946,6 +7947,7 @@ const QEMUOption qemu_options[] = {
 #endif
     { "clock", HAS_ARG, QEMU_OPTION_clock },
     { "startdate", HAS_ARG, QEMU_OPTION_startdate },
+    { "vga", HAS_ARG, QEMU_OPTION_vga },
     { NULL },
 };
 
@@ -8793,6 +8795,21 @@ int main(int argc, char **argv)
                         }
                         rtc_date_offset = time(NULL) - rtc_start_date;
                     }
+                }
+                break;
+            case QEMU_OPTION_vga:
+                if (!strcmp(optarg, "cirrus")) {
+                    cirrus_vga_enabled = 1;
+                    vmsvga_enabled = 0;
+                } else if (!strcmp(optarg, "std")) {
+                    cirrus_vga_enabled = 0;
+                    vmsvga_enabled = 0;
+                } else if (!strcmp(optarg, "vmware")) {
+                    cirrus_vga_enabled = 0;
+                    vmsvga_enabled = 1;
+                } else {
+                    fprintf(stderr, "Supported vga cards: cirrus, std, vmware\n");
+                    exit(1);
                 }
                 break;
             }


- Sebastian