From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XoSaL-0000rS-BS for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:43:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XoSaF-0005SM-1d for qemu-devel@nongnu.org; Wed, 12 Nov 2014 02:43:25 -0500 From: SeokYeon Hwang References: <1415775949-4528-1-git-send-email-syeon.hwang@samsung.com> <87egt8c1qn.fsf@blackfin.pond.sub.org> In-reply-to: <87egt8c1qn.fsf@blackfin.pond.sub.org> Date: Wed, 12 Nov 2014 16:43:06 +0900 Message-id: <027b01cffe4c$4c809ae0$e581d0a0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Content-language: ko Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno to 'error_set_errno()' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Markus Armbruster' Cc: "'Michael S. Tsirkin'" , qemu-trivial@nongnu.org, kongjianjun@gmail.com, paolo.bonzini@gmail.com, qemu-devel@nongnu.org, mreitz@redhat.com > -----Original Message----- > From: Markus Armbruster [mailto:armbru@redhat.com] > Sent: Wednesday, November 12, 2014 4:33 PM > To: SeokYeon Hwang > Cc: qemu-devel@nongnu.org; kongjianjun@gmail.com; paolo.bonzini@gmail.com; > mreitz@redhat.com; qemu-trivial@nongnu.org; Michael S. Tsirkin > Subject: Re: [Qemu-devel] [PATCH for-2.2] pci: Don't pass negative errno > to 'error_set_errno()' > > Copying maintainer and -trivial. > > In the future, please copy maintainers. You can use > "scripts/get_maintainer.pl --no-git-fallback" to find them. Thank you for your help. > > SeokYeon Hwang writes: > > > Signed-off-by: SeokYeon Hwang > > --- > > hw/pci/pcie.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 58455bd..2902f7d > > 100644 > > --- a/hw/pci/pcie.c > > +++ b/hw/pci/pcie.c > > @@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice > *hotplug_dev, > > /* the slot is electromechanically locked. > > * This error is propagated up to qdev and then to HMP/QMP. > > */ > > - error_setg_errno(errp, -EBUSY, "slot is electromechanically > locked"); > > + error_setg_errno(errp, EBUSY, "slot is electromechanically > > + locked"); > > } > > } > > Reviewed-by: Markus Armbruster