From: Chinmay Rath <rathc@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Nicholas Piggin" <npiggin@gmail.com>,
kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH v2 07/11] target/ppc/kvm: Remove kvmppc_get_host_model() as unused
Date: Tue, 21 Oct 2025 17:09:11 +0530 [thread overview]
Message-ID: <028fdb03-7bee-4a76-932e-a9247db2f2ac@linux.ibm.com> (raw)
In-Reply-To: <20251021084346.73671-8-philmd@linaro.org>
On 10/21/25 14:13, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/ppc/kvm_ppc.h | 6 ------
> target/ppc/kvm.c | 5 -----
> 2 files changed, 11 deletions(-)
>
> diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h
> index f24cc4de3c2..742881231e1 100644
> --- a/target/ppc/kvm_ppc.h
> +++ b/target/ppc/kvm_ppc.h
> @@ -21,7 +21,6 @@
>
> uint32_t kvmppc_get_tbfreq(void);
> uint64_t kvmppc_get_clockfreq(void);
> -bool kvmppc_get_host_model(char **buf);
> int kvmppc_get_hasidle(CPUPPCState *env);
> int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_len);
> int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level);
> @@ -128,11 +127,6 @@ static inline uint32_t kvmppc_get_tbfreq(void)
> return 0;
> }
>
> -static inline bool kvmppc_get_host_model(char **buf)
> -{
> - return false;
> -}
> -
> static inline uint64_t kvmppc_get_clockfreq(void)
> {
> return 0;
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index cb61e99f9d4..43124bf1c78 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -1864,11 +1864,6 @@ uint32_t kvmppc_get_tbfreq(void)
> return cached_tbfreq;
> }
>
> -bool kvmppc_get_host_model(char **value)
> -{
> - return g_file_get_contents("/proc/device-tree/model", value, NULL, NULL);
> -}
> -
> /* Try to find a device tree node for a CPU with clock-frequency property */
> static int kvmppc_find_cpu_dt(char *buf, int buf_len)
> {
Reviewed-by: Chinmay Rath <rathc@linux.ibm.com>
next prev parent reply other threads:[~2025-10-21 11:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 8:43 [PATCH v2 00/11] hw/ppc/spapr: Remove deprecated pseries-3.0 -> pseries-4.2 machines Philippe Mathieu-Daudé
2025-10-21 8:43 ` [PATCH v2 01/11] ppc/spapr: remove deprecated machine pseries-3.0 Philippe Mathieu-Daudé
2025-10-21 8:43 ` [PATCH v2 02/11] hw/ppc/spapr: Remove SpaprMachineClass::nr_xirqs field Philippe Mathieu-Daudé
2025-10-21 10:35 ` Chinmay Rath
2025-10-22 7:17 ` Chinmay Rath
2025-10-21 8:43 ` [PATCH v2 03/11] ppc/spapr: remove deprecated machine pseries-3.1 Philippe Mathieu-Daudé
2025-10-21 8:43 ` [PATCH v2 04/11] hw/ppc/spapr: Inline spapr_dtb_needed() Philippe Mathieu-Daudé
2025-10-21 13:25 ` Chinmay Rath
2025-10-21 14:21 ` Philippe Mathieu-Daudé
2025-10-22 7:03 ` Chinmay Rath
2025-10-21 8:43 ` [PATCH v2 05/11] hw/ppc/spapr: Inline few SPAPR_IRQ_* uses Philippe Mathieu-Daudé
2025-10-21 11:27 ` Chinmay Rath
2025-10-21 8:43 ` [PATCH v2 06/11] target/ppc/kvm: Remove kvmppc_get_host_serial() as unused Philippe Mathieu-Daudé
2025-10-21 11:36 ` Chinmay Rath
2025-10-21 8:43 ` [PATCH v2 07/11] target/ppc/kvm: Remove kvmppc_get_host_model() " Philippe Mathieu-Daudé
2025-10-21 11:39 ` Chinmay Rath [this message]
2025-10-21 8:43 ` [PATCH v2 08/11] ppc/spapr: remove deprecated machine pseries-4.0 Philippe Mathieu-Daudé
2025-10-21 8:43 ` [PATCH v2 09/11] hw/ppc/spapr: Remove SpaprMachineClass::phb_placement callback Philippe Mathieu-Daudé
2025-10-21 11:48 ` Chinmay Rath
2025-10-21 8:43 ` [PATCH v2 10/11] ppc/spapr: remove deprecated machine pseries-4.1 Philippe Mathieu-Daudé
2025-10-21 8:43 ` [PATCH v2 11/11] ppc/spapr: remove deprecated machine pseries-4.2 Philippe Mathieu-Daudé
2025-10-21 11:07 ` [PATCH v2 00/11] hw/ppc/spapr: Remove deprecated pseries-3.0 -> pseries-4.2 machines Michal Suchánek
2025-10-29 17:30 ` Shivaprasad G Bhat
2025-10-29 19:53 ` Michal Suchánek
2025-10-23 11:47 ` Harsh Prateek Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028fdb03-7bee-4a76-932e-a9247db2f2ac@linux.ibm.com \
--to=rathc@linux.ibm.com \
--cc=clg@redhat.com \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).