qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: qemu-devel@nongnu.org
Cc: 'Markus Armbruster' <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH] Do not fail if id field is present.
Date: Fri, 05 Jun 2015 17:17:29 +0300	[thread overview]
Message-ID: <02aa01d09f9a$5bb198d0$1314ca70$@samsung.com> (raw)

This fixes QMP regression:
http://lists.gnu.org/archive/html/qemu-devel/2015-06/msg01795.html

Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
---
 monitor.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/monitor.c b/monitor.c
index c7baa91..ef21bba 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4955,6 +4955,8 @@ static QDict *qmp_check_input_obj(QObject *input_obj, Error **errp)
                           "arguments", "object");
                 return NULL;
             }
+        } else if (!strcmp(arg_name, "id")) {
+            /* Ignored, necessary for backwards compatibility */
         } else {
             error_set(errp, QERR_QMP_EXTRA_MEMBER, arg_name);
             return NULL;
-- 
1.9.5.msysgit.0

             reply	other threads:[~2015-06-05 14:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 14:17 Pavel Fedin [this message]
2015-06-05 14:32 ` [Qemu-devel] [PATCH] Do not fail if id field is present Daniel P. Berrange
2015-06-05 22:10   ` Eric Blake
2015-06-08  8:08     ` Markus Armbruster
2015-06-08  8:24       ` Paolo Bonzini
2015-06-05 14:36 ` Paolo Bonzini
2015-06-08  8:10   ` Markus Armbruster
2015-06-08  8:17     ` Paolo Bonzini
2015-06-08  8:26       ` Wen Congyang
2015-06-05 15:43 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02aa01d09f9a$5bb198d0$1314ca70$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).