From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: mcascell@redhat.com, remy.noel@blade-group.com
Subject: Re: [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527)
Date: Mon, 3 May 2021 11:57:09 +0200 [thread overview]
Message-ID: <02b72bdb-96a2-d0b1-ca7b-1ba9cccdafd3@redhat.com> (raw)
In-Reply-To: <a65a7b1b-5dff-dd0c-2e00-4eafc1639bab@redhat.com>
On 5/3/21 11:27 AM, Philippe Mathieu-Daudé wrote:
> On 5/3/21 11:14 AM, Gerd Hoffmann wrote:
>> Use autofree heap allocation instead.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Fixes: 4f4321c11ff ("usb: use iovecs in USBPacket")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Hmm there is still another use:
618 if (dev->endpoint[EP2I(ep)].iso_started) {
619 struct usb_redir_iso_packet_header iso_packet = {
620 .endpoint = ep,
621 .length = p->iov.size
622 };
623 uint8_t buf[p->iov.size];
next prev parent reply other threads:[~2021-05-03 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 9:14 [PATCH 0/5] usb: fix some memory allocation issues Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 1/5] usb/hid: avoid dynamic stack allocation Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 2/5] usb/redir: avoid dynamic stack allocation (CVE-2021-3527) Gerd Hoffmann
2021-05-03 9:27 ` Philippe Mathieu-Daudé
2021-05-03 9:57 ` Philippe Mathieu-Daudé [this message]
2021-05-03 9:14 ` [PATCH 3/5] usb/mtp: avoid dynamic stack allocation Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 4/5] usb/xhci: sanity check packet size Gerd Hoffmann
2021-05-03 9:14 ` [PATCH 5/5] usb: limit combined packets to 1 MiB Gerd Hoffmann
2021-05-03 9:47 ` [PATCH 0/5] usb: fix some memory allocation issues Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02b72bdb-96a2-d0b1-ca7b-1ba9cccdafd3@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=mcascell@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=remy.noel@blade-group.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).