From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsxJ5-0000A4-Q9 for qemu-devel@nongnu.org; Sat, 08 Oct 2016 15:29:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsxIz-0005vc-K0 for qemu-devel@nongnu.org; Sat, 08 Oct 2016 15:29:14 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42123) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsxIz-0005rO-BV for qemu-devel@nongnu.org; Sat, 08 Oct 2016 15:29:09 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u98JNnEs064629 for ; Sat, 8 Oct 2016 15:29:02 -0400 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 25xwabb55k-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 08 Oct 2016 15:29:02 -0400 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 8 Oct 2016 20:29:00 +0100 References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com> <1475519097-27611-5-git-send-email-duanj@linux.vnet.ibm.com> <20161005165638.GC11921@work-vm> <20161006190156.GE3087@work-vm> <6420ae77-c205-6e24-d06e-2bbb28447b23@redhat.com> <20161007143445.GA25928@work-vm> <72a0ee2a-297c-02cd-1af5-215ad463b474@linux.vnet.ibm.com> <7e2948b3-0e29-b87c-78bd-d5070efb3342@redhat.com> <32187d3f-d1c1-b14a-ebf6-f01526359bdb@linux.vnet.ibm.com> <20161007173448.GD25928@work-vm> <769fa4cd-4960-396e-c2ae-c11508f69f0d@redhat.com> From: Halil Pasic Date: Sat, 8 Oct 2016 21:28:43 +0200 MIME-Version: 1.0 In-Reply-To: <769fa4cd-4960-396e-c2ae-c11508f69f0d@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fkk7hT3ld5dC52PwHB8u1TnUWohsxF90Q" Message-Id: <02caeaca-5a35-4efa-39be-772d1a314d74@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Jianjun Duan , "Dr. David Alan Gilbert" Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, quintela@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, kraxel@redhat.com, dmitry@daynix.com, kwolf@redhat.com, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fkk7hT3ld5dC52PwHB8u1TnUWohsxF90Q From: Halil Pasic To: Paolo Bonzini , Jianjun Duan , "Dr. David Alan Gilbert" Cc: veroniabahaa@gmail.com, peter.maydell@linaro.org, mdroth@linux.vnet.ibm.com, mst@redhat.com, quintela@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, mreitz@redhat.com, blauwirbel@gmail.com, amit.shah@redhat.com, qemu-ppc@nongnu.org, kraxel@redhat.com, dmitry@daynix.com, kwolf@redhat.com, rth@twiddle.net, leon.alrae@imgtec.com, aurelien@aurel32.net, david@gibson.dropbear.id.au Message-ID: <02caeaca-5a35-4efa-39be-772d1a314d74@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 4/6] migration: migrate QTAILQ References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com> <1475519097-27611-5-git-send-email-duanj@linux.vnet.ibm.com> <20161005165638.GC11921@work-vm> <20161006190156.GE3087@work-vm> <6420ae77-c205-6e24-d06e-2bbb28447b23@redhat.com> <20161007143445.GA25928@work-vm> <72a0ee2a-297c-02cd-1af5-215ad463b474@linux.vnet.ibm.com> <7e2948b3-0e29-b87c-78bd-d5070efb3342@redhat.com> <32187d3f-d1c1-b14a-ebf6-f01526359bdb@linux.vnet.ibm.com> <20161007173448.GD25928@work-vm> <769fa4cd-4960-396e-c2ae-c11508f69f0d@redhat.com> In-Reply-To: <769fa4cd-4960-396e-c2ae-c11508f69f0d@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/08/2016 01:37 PM, Paolo Bonzini wrote: >> Even though most put/get have no issues now, when somebody writes a ne= w >> > put, he or she could run into issues if only checking the type >> > signature. It makes the code more readable. > No, it doesn't because one is left wondering what is VMS_LINKED about. I agree with Paolo. IMHO VMS_LINKED is conceptually difficult in a sense= that it's quite different that what we have currently. I have the feeling= , conceptually, we are trying to fit in something like data structures with= a type parameter (the element type) here. AFAIU what vmstate currently can = is directed acyclic graphs of certain stuff (and also completely custom handling based on custom put/get). > What is the relation between linked datastructures and passing some > arguments as NULL/noon-NULL? IFAIU we need those for the datastructure because it's linked and has a type parameter (element type). The two last arguments are for the element type. These were added by the previous patch because the old VMStateInfo did not need these. So we drastically changed the scope of VMStateInfo with the previous patch and I'm not sure I like this. I will have to stare at this a bit longer to bring something more constructive than these (largely feeling-based) remarks. Cheers, Halil --fkk7hT3ld5dC52PwHB8u1TnUWohsxF90Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAEBAgAGBQJX+Uj1AAoJEA0vhuyXGx0A2M4P/Rc4b0BdJF+xh8738TXgkJXw KwI+VFK2CySa2pq0zieFMvwrbVi9ocxsWUSOpBO4/7t12qmiON+yGt+EY4uzV4JL GLEXChZG85eTVdAl8q11jLoKlc7ZKbBqlfxT5fG893gf5NWp44Zt3idRoFY9T1yM ph5LFZIeS4R9VEnvEhQPBT7Cabu7myTazhkn1+LiBREERG3ATtvI1JLEbbQT/Gvl sUdT7ISfIVhYaihpR1QeCSdKpJgAWFont8t8YM1t7caTnYeccL+IoIZE2X/p3Zvh AgNX7Z5VqYF+0y6cVnHZe/qv5xiX+6vP0tElPZJrars2ZgQyFm0jUILJii/bPQCO tDC+hZp/R0neWHsESiAaz4XfYt5Pg/sl0ZuzEWzZdPiZDw/Nh6mt8UJg9+ViGgeH x2Cp78qW+aYVAo7iWzS+dkL7hce6uhEtmZmQWnIOqEOCerfDYs0QzJiILfTUsP7a XCuyGvKkH3230ScprdnZJ6pZld3LGryO4De5Hx+PMp5GYTiV4mcVHegxo5CIcLUU v3RCwtcAROMYxxbkuR/4s3oVtabzp8cWtqEEKy4uBQRRb2rbgN8ckY6FoyhsSI2N mcFWps5rZC27cGRGP2usoLrnWh3ODz8D0cgsS2T3A/SzRp7QKlSmbNVGkC3353OM xv3sxGNHQ3WFtgYJP0/L =8Xe3 -----END PGP SIGNATURE----- --fkk7hT3ld5dC52PwHB8u1TnUWohsxF90Q--