From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 06/24] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header
Date: Mon, 11 Dec 2023 15:00:06 -0800 [thread overview]
Message-ID: <02cfd4a9-9d6c-4f61-b25e-deb0cbec2838@linaro.org> (raw)
In-Reply-To: <20231211212003.21686-7-philmd@linaro.org>
On 12/11/23 13:19, Philippe Mathieu-Daudé wrote:
> Nothing in guestfd.c requires "semihosting/uaccess.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> semihosting/guestfd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/semihosting/guestfd.c b/semihosting/guestfd.c
> index 955c2efbd0..fd7e609790 100644
> --- a/semihosting/guestfd.c
> +++ b/semihosting/guestfd.c
> @@ -15,7 +15,6 @@
> #ifdef CONFIG_USER_ONLY
> #include "qemu.h"
> #else
> -#include "semihosting/uaccess.h"
Then I would be surprised if qemu.h is required either -- that's where uaccess is done for
user-only.
r~
next prev parent reply other threads:[~2023-12-11 23:00 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 21:19 [PATCH 00/24] exec: Rework of various headers (user focused) Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 01/24] exec: Include 'cpu.h' before validating CPUArchState placement Philippe Mathieu-Daudé
2023-12-11 21:53 ` Warner Losh
2023-12-11 21:55 ` Warner Losh
2023-12-11 21:19 ` [PATCH 02/24] exec: Expose 'target_page.h' API to user emulation Philippe Mathieu-Daudé
2023-12-11 21:54 ` Warner Losh
2023-12-11 22:14 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 03/24] target: Define TCG_GUEST_DEFAULT_MO in 'cpu-param.h' Philippe Mathieu-Daudé
2023-12-11 21:27 ` Philippe Mathieu-Daudé
2023-12-11 22:18 ` Richard Henderson
2023-12-22 4:36 ` Nicholas Piggin
2023-12-11 21:19 ` [PATCH 04/24] accel: Include missing 'exec/cpu_ldst.h' header Philippe Mathieu-Daudé
2023-12-11 22:20 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 05/24] semihosting/uaccess: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2023-12-11 22:58 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 06/24] semihosting/guestfd: Remove unused 'semihosting/uaccess.h' header Philippe Mathieu-Daudé
2023-12-11 23:00 ` Richard Henderson [this message]
2023-12-12 11:40 ` Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 07/24] host/load-extract: Include missing 'qemu/atomic.h' and 'qemu/int128.h' Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 08/24] host/atomic128: Include missing 'qemu/atomic.h' header Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 09/24] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header Philippe Mathieu-Daudé
2023-12-22 4:37 ` Nicholas Piggin
2023-12-11 21:19 ` [PATCH 10/24] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 11/24] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 12/24] target/i386: Include missing 'exec/exec-all.h' header Philippe Mathieu-Daudé
2023-12-11 23:04 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 13/24] accel/tcg: Include missing 'hw/core/cpu.h' header Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 14/24] gdbstub: " Philippe Mathieu-Daudé
2023-12-11 21:57 ` Warner Losh
2023-12-11 21:19 ` [PATCH 15/24] exec/cpu-all: Remove unused headers Philippe Mathieu-Daudé
2023-12-11 23:16 ` Richard Henderson
2023-12-12 12:24 ` Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 16/24] exec/cpu-all: Reduce 'qemu/rcu.h' header inclusion Philippe Mathieu-Daudé
2023-12-11 23:08 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 17/24] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation Philippe Mathieu-Daudé
2023-12-22 4:37 ` Nicholas Piggin
2023-12-11 21:19 ` [PATCH 18/24] accel/tcg: Un-inline retaddr helpers to 'user-retaddr.h' Philippe Mathieu-Daudé
2023-12-11 23:24 ` Richard Henderson
2023-12-11 21:19 ` [PATCH 19/24] exec/user: Do not include 'cpu.h' in 'abitypes.h' Philippe Mathieu-Daudé
2023-12-11 23:29 ` Richard Henderson
2023-12-12 10:15 ` Philippe Mathieu-Daudé
2023-12-12 10:45 ` Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 20/24] exec: Declare abi_ptr type in its own 'tcg/abi_ptr.h' header Philippe Mathieu-Daudé
2023-12-11 21:28 ` Philippe Mathieu-Daudé
2023-12-12 1:18 ` Richard Henderson
2023-12-12 10:13 ` Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 21/24] exec/cpu_ldst: Avoid including 'cpu.h' Philippe Mathieu-Daudé
2023-12-11 21:19 ` [PATCH 22/24] exec/cpu-all: Restrict inclusion of 'exec/user/guest-base.h' Philippe Mathieu-Daudé
2023-12-12 1:25 ` Richard Henderson
2023-12-11 21:20 ` [PATCH 23/24] exec/cpu-all: Extract page-protection definitions to page-prot-common.h Philippe Mathieu-Daudé
2023-12-22 8:06 ` Nicholas Piggin
2023-12-26 15:22 ` Philippe Mathieu-Daudé
2023-12-11 21:20 ` [PATCH 24/24] target: Restrict 'sysemu/reset.h' to system emulation Philippe Mathieu-Daudé
2023-12-11 21:58 ` Warner Losh
2023-12-12 1:24 ` gaosong
2023-12-11 21:22 ` [PATCH 00/24] exec: Rework of various headers (user focused) Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cfd4a9-9d6c-4f61-b25e-deb0cbec2838@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).