From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrange" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)
Date: Tue, 10 Nov 2020 18:21:09 -0200 [thread overview]
Message-ID: <02d261af-a8b8-571c-9a4a-b33a5dd0b5a2@redhat.com> (raw)
In-Reply-To: <20201108221925.2344515-3-philmd@redhat.com>
On 11/8/20 8:19 PM, Philippe Mathieu-Daudé wrote:
> 'extends' is an alternative to using YAML anchors
> and is a little more flexible and readable. See:
> https://docs.gitlab.com/ee/ci/yaml/#extends
Good idea!
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> .gitlab-ci.d/crossbuilds.yml | 40 ++++++++++++++++++------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
>
> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> index 03ebfabb3fa..099949aaef3 100644
> --- a/.gitlab-ci.d/crossbuilds.yml
> +++ b/.gitlab-ci.d/crossbuilds.yml
> @@ -1,5 +1,5 @@
>
> -.cross_system_build_job_template: &cross_system_build_job_definition
> +.cross_system_build_job:
> stage: build
> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> timeout: 80m
> @@ -13,7 +13,7 @@
> xtensa-softmmu"
> - make -j$(expr $(nproc) + 1) all check-build
>
> -.cross_user_build_job_template: &cross_user_build_job_definition
> +.cross_user_build_job:
> stage: build
> image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:latest
> script:
> @@ -24,91 +24,91 @@
> - make -j$(expr $(nproc) + 1) all check-build
>
> cross-armel-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-armel-cross
>
> cross-armel-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-armel-cross
>
> cross-armhf-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-armhf-cross
>
> cross-armhf-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-armhf-cross
>
> cross-arm64-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-arm64-cross
>
> cross-arm64-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-arm64-cross
>
> cross-mips-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-mips-cross
>
> cross-mips-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-mips-cross
>
> cross-mipsel-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-mipsel-cross
>
> cross-mipsel-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-mipsel-cross
>
> cross-mips64el-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-mips64el-cross
>
> cross-mips64el-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-mips64el-cross
>
> cross-ppc64el-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-ppc64el-cross
>
> cross-ppc64el-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-ppc64el-cross
>
> cross-s390x-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: debian-s390x-cross
>
> cross-s390x-user:
> - <<: *cross_user_build_job_definition
> + extends: .cross_user_build_job
> variables:
> IMAGE: debian-s390x-cross
>
> cross-win32-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: fedora-win32-cross
>
> cross-win64-system:
> - <<: *cross_system_build_job_definition
> + extends: .cross_system_build_job
> variables:
> IMAGE: fedora-win64-cross
next prev parent reply other threads:[~2020-11-10 20:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 22:19 [PATCH v3 00/11] gitlab-ci: Allow forks to select & restrict build jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 01/11] gitlab-ci: Drop generic cache rule Philippe Mathieu-Daudé
2020-11-09 9:46 ` Thomas Huth
2020-11-08 22:19 ` [PATCH v3 02/11] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-11-10 20:21 ` Wainer dos Santos Moschetta [this message]
2020-11-08 22:19 ` [PATCH v3 03/11] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2020-11-10 20:23 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 04/11] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2020-11-10 20:24 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 05/11] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2020-11-10 20:35 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 06/11] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2020-11-10 20:42 ` Wainer dos Santos Moschetta
2020-11-12 7:02 ` Thomas Huth
2020-11-12 20:31 ` Wainer dos Santos Moschetta
2020-11-16 12:56 ` Philippe Mathieu-Daudé
2020-11-23 15:36 ` Willian Rampazzo
2020-11-08 22:19 ` [PATCH v3 07/11] gitlab-ci: Extract common job definition as 'cross_common_job' Philippe Mathieu-Daudé
2020-11-09 9:52 ` Thomas Huth
2020-11-10 10:23 ` Philippe Mathieu-Daudé
2020-11-10 20:43 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 08/11] gitlab-ci: Extract common job definition as 'native_common_job' Philippe Mathieu-Daudé
2020-11-10 20:54 ` Wainer dos Santos Moschetta
2020-11-08 22:19 ` [PATCH v3 09/11] gitlab-ci: Add rules to select cross-jobs to build Philippe Mathieu-Daudé
2020-11-09 9:57 ` Thomas Huth
2020-11-08 22:19 ` [PATCH v3 10/11] gitlab-ci: Add rules to select building/testing native jobs Philippe Mathieu-Daudé
2020-11-08 22:19 ` [PATCH v3 11/11] gitlab-ci: Move artifacts expiry rule to common 'native_build_job' Philippe Mathieu-Daudé
2020-11-09 9:59 ` Thomas Huth
2020-11-16 13:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02d261af-a8b8-571c-9a4a-b33a5dd0b5a2@redhat.com \
--to=wainersm@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).