From: Hanna Reitz <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] ide: Explicitly poll for BHs on cancel
Date: Wed, 5 Jan 2022 14:53:16 +0100 [thread overview]
Message-ID: <02e74087-fed3-86da-1987-77deadfbaa1a@redhat.com> (raw)
In-Reply-To: <20220105111337.10366-1-hreitz@redhat.com>
On 05.01.22 12:13, Hanna Reitz wrote:
[...]
> Perhaps for a lack of being aware of all the kinds of tests we have, I
> found it impossible to write a reproducer in any of our current test
> frameworks: From how I understand the issue, to reproduce it, you need
> to issue a TRIM request and immediately cancel it, before
> ide_trim_bh_cb() (scheduled as a BH) can run.
>
> I wanted to do this via qtest, but that does not work, because every
> port I/O operation is done via a qtest command, and QEMU will happily
> poll the main context between each qtest command, which means that you
> cannot cancel an ongoing IDE request before a BH scheduled by it is run.
>
> Therefore, I wrote an x86 boot sector that sets up a no-op TRIM request
> (i.e. one where all TRIM ranges have length 0) and immediately cancels
> it by setting SRST.
I just realized we could, if we really wanted to, add this to the
iotests’ sample_images directory, and then run it from an iotest...
Hanna
next prev parent reply other threads:[~2022-01-05 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 11:13 [PATCH] ide: Explicitly poll for BHs on cancel Hanna Reitz
2022-01-05 13:53 ` Hanna Reitz [this message]
2022-01-06 0:11 ` Philippe Mathieu-Daudé
2022-01-07 8:05 ` Mark Cave-Ayland
2022-01-19 11:11 ` Paolo Bonzini
2022-01-19 11:29 ` Hanna Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02e74087-fed3-86da-1987-77deadfbaa1a@redhat.com \
--to=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).