From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C44C433DB for ; Sun, 24 Jan 2021 00:34:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1626F225AC for ; Sun, 24 Jan 2021 00:34:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1626F225AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3TLw-0000kb-UW for qemu-devel@archiver.kernel.org; Sat, 23 Jan 2021 19:34:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3TL3-0007m9-TJ for qemu-devel@nongnu.org; Sat, 23 Jan 2021 19:33:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51372) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l3TL0-0006tU-K5 for qemu-devel@nongnu.org; Sat, 23 Jan 2021 19:33:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611448383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S+pI06b1r7YH4VIqSs+vN3SRg66T2NtRWpxktrRjGR8=; b=SSOkzPq2Ftcnt+aA0gUpoqLq0lezB3ZVGUZoT/hIEsVSpTcBu4KkVbnTmR7p4FyjYVPJ/H CgUzkOUBn57Cf+QAd5Qn7vaKkfIsb7nMJHvFn8VtEzIXZ3qoW5/lRQXICKxx825VKl6prc sN2ghKMGotSKOlvfX27RrB8KvTAGsP0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-fMtS-kfSMJSgTAA62sNBFQ-1; Sat, 23 Jan 2021 19:33:01 -0500 X-MC-Unique: fMtS-kfSMJSgTAA62sNBFQ-1 Received: by mail-wr1-f71.google.com with SMTP id w5so5246644wrl.9 for ; Sat, 23 Jan 2021 16:33:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S+pI06b1r7YH4VIqSs+vN3SRg66T2NtRWpxktrRjGR8=; b=E8rEYSHW8Nit7Uzms5Ug8TtP+H/lGZrNeLQvTO09fjScBEOBonEA8wuicyiyAVKOuH Zxarg4LJMzeecswDD9+7WWJb81eKcSftd+oHG8fB0lV9ne/87/6PUZTT+feGtaBNEKhz FoiHS1/GVmrZlHsW/OyrjzeQwadBjgGIIn//ETJ+6YJvfosxWY/9CFjqD9xVG2tnXW6s NbZDM9nkZOzl3/XUKsdF0Nz1JeRNYvwCPp7/xanX0E67rQGyvxPqMXCzROEReRP6hFMP 6dhKJKvHV/zEoxkvBT0orG10mvAfcQigRIxHAbv3H6zCWQexmYKfpmCr94GMRl+9Q6wZ dLJw== X-Gm-Message-State: AOAM531KRwh80ul2MLr1Lf7ESoiPPGY7Tvfyo91tfhVBC8HMt/0Rc6ZT 3ndVuRdERlb3sUHTb5fWW69EZZ9DDfoP/G5B+NyE5WEa854EH5dlgeAf/neGsBejYc85JTMFVCl aXDu74XWkhdr+W70= X-Received: by 2002:a1c:398a:: with SMTP id g132mr9818633wma.38.1611448380066; Sat, 23 Jan 2021 16:33:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRb1UPdNWZ+xxetAXm28cs/w2nyBPbN3n+9EIYtk6KSJ4BL0PJHNV0nbxFN5s3x+EWLlFDKg== X-Received: by 2002:a1c:398a:: with SMTP id g132mr9818614wma.38.1611448379817; Sat, 23 Jan 2021 16:32:59 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id v6sm16380966wrx.32.2021.01.23.16.32.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Jan 2021 16:32:59 -0800 (PST) Subject: Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210122204441.2145197-1-philmd@redhat.com> <20210122204441.2145197-10-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <02ef2d7f-ac16-af21-a002-bc2165646dfc@redhat.com> Date: Sun, 24 Jan 2021 01:32:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.165, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , Michael Roth , Markus Armbruster , Laurent Vivier , Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/23/21 7:10 PM, Paolo Bonzini wrote: > On 22/01/21 21:44, Philippe Mathieu-Daudé wrote: >> Beside a CPU device, user-mode emulation doesn't access >> anything else from qdev subsystem. >> >> Tools don't need anything from qdev. > > I prefer to avoid stubs.  So if this patch can simply be dropped with no > effects on 10-12, that's nicer for me. The alternative is ugly: -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..d09f32e38d6 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -950,7 +950,9 @@ static void device_finalize(Object *obj) if (dev->pending_deleted_event) { g_assert(dev->canonical_path); +#ifdef CONFIG_USER_ONLY qapi_event_send_device_deleted(!!dev->id, dev->id, dev->canonical_path); +#endif g_free(dev->canonical_path); dev->canonical_path = NULL; } --- Maybe wrapping it in an inlined function?