From: <luoyifan@cmss.chinamobile.com>
To: <qemu-devel@nongnu.org>
Cc: imammedo@redhat.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH] tests/rebuild-expected-aml.sh: Modern shell scripting (use $() instead of ``)
Date: Fri, 11 Oct 2019 16:26:55 +0800 [thread overview]
Message-ID: <02f501d5800d$a4a059c0$ede10d40$@cmss.chinamobile.com> (raw)
In-Reply-To:
Various shell files contain a mix of obsolete `` and
modern $(); It would be nice to convert to use $()
everywhere.
Signed-off-by: Yifan Luo <luoyifan@cmss.chinamobile.com>
---
tests/data/acpi/rebuild-expected-aml.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/data/acpi/rebuild-expected-aml.sh
b/tests/data/acpi/rebuild-expected-aml.sh
index f89d462..07c5814 100755
--- a/tests/data/acpi/rebuild-expected-aml.sh
+++ b/tests/data/acpi/rebuild-expected-aml.sh
@@ -29,7 +29,7 @@ for qemu in $qemu_bins; do
TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test
done
-eval `grep SRC_PATH= config-host.mak`
+eval $(grep SRC_PATH= config-host.mak)
echo '/* List of comma-separated changed AML files to ignore */' >
${SRC_PATH}/tests/bios-tables-test-allowed-diff.h
--
1.8.3.1
reply other threads:[~2019-10-11 8:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02f501d5800d$a4a059c0$ede10d40$@cmss.chinamobile.com' \
--to=luoyifan@cmss.chinamobile.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).