From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThEzj-0002yg-US for qemu-devel@nongnu.org; Sat, 08 Dec 2012 02:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThEzi-00012C-SK for qemu-devel@nongnu.org; Sat, 08 Dec 2012 02:38:43 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:58579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThEzi-000126-LP for qemu-devel@nongnu.org; Sat, 08 Dec 2012 02:38:42 -0500 Message-ID: <02f62b0eb0d86e5086f4f6f95b213bc4.squirrel@weilnetz.de> In-Reply-To: <1354925118-23061-1-git-send-email-keith.busch@intel.com> References: <1354925118-23061-1-git-send-email-keith.busch@intel.com> Date: Sat, 8 Dec 2012 08:38:39 +0100 From: "Stefan Weil" MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Keith Busch Cc: qemu-devel@nongnu.org, Keith Busch , "Michael S. Tsirkin" > An implementation of a generic NVMe Controller PCI device, developed > from the open standard available at nvmexpress.org. > > Cc: Michael S. Tsirkin > Cc: Keith Busch > Signed-off-by: Keith Busch > --- > I've developed for QEMU for a little while, but this is my first patch,= so > I wouldn't be the least bit surprised if I broke some qemu dev rules. > > I wasn't sure if I should submit this as really I think only driver > developers would be interested. Since it is a fairly large patch, maybe > no one would review it if they don't already have an interest in NVM > Express, but we found emulation quite helpful in driver development as > real hardware is only recently starting to be released, and hope others > others might find this helpful too. So if this is accepted, us driver > developers can get all the benefits of the latest QEMU without managing > our own branch like we're doing today! :) > > This implementation tries to use the loosest possible constraints the > standard allows. Potential settings not settable by the host driver at > run-time can be adjusted with the device properties when starting qemu. > This patch or some variant was tested against guest instances with driv= ers > developed for Linux, Win2k8 OFA, FreeBSD, UEFI, and, interestingly > enough, ESXi 5.1. I did not test every possible combination of paramete= rs, > though. > > One thing I wanted to note: I tried to use the QEMU thread library > exclusively instead of posix, but it is lacking read/write locks, so > there is some pthread stuff here if that's okay. > Hi, new contributions should use "GNU GPL v2 or later" instead of "GNU GPL v2= ". Compilation with MinGW-w64 fails: qemu/hw/nvme.c:61:22: fatal error: sys/mman.h: No such file or directory compilation terminated. make: *** [hw/nvme.o] Error 1 I expect that the pthread stuff will also be missing for MinGW-w64. Regards Stefan Weil