qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.ibm.com>
To: dan tan <dantan@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, stefanb@linux.vnet.ibm.com,
	pbonzini@redhat.com, farosas@suse.de, lvivier@redhat.com,
	clg@kaod.org
Subject: Re: [PATCH v3 0/5] TPM TIS SPI Support
Date: Fri, 1 Nov 2024 15:25:52 -0400	[thread overview]
Message-ID: <0333d608-087e-4a8e-9937-7c97013a0bd4@linux.ibm.com> (raw)
In-Reply-To: <20241101185718.5847-1-dantan@linux.vnet.ibm.com>



On 11/1/24 2:57 PM, dan tan wrote:
> *** BLURB HERE ***
> 
> Support TPM for SPI (Serial Peripheral Interface)
> 
> Revision 3 summary:
>    device support:
>      - moved variable tis_addr from TPMStateSPI struct to local
>      - added the VM suspend/resume support:
>        - added vmstate_tpm_tis_spi declaration
>        - added tpm_tis_spi_pre_save() function
>      - fixed trace formatting string

Can you please update patch 1/3 with those changes relevant for this 
patch and then patch 3/3 as well. I think it should be fairly simple to 
modify each one of them by merging 4/5 into 1/5 and 5/5 into 3/5. 
There's no reason that there are so many changes in 4/5 and 5/5 
replacing new code.

   Thanks
     Stefan



      parent reply	other threads:[~2024-11-01 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-01 18:57 [PATCH v3 0/5] TPM TIS SPI Support dan tan
2024-11-01 18:57 ` [PATCH v3 1/5] tpm/tpm_tis_spi: Support TPM for SPI (Serial Peripheral Interface) dan tan
2024-11-01 18:57 ` [PATCH v3 2/5] tpm/tpm_tis_spi: activation for the PowerNV machines dan tan
2024-11-01 18:57 ` [PATCH v3 3/5] tests/qtest/tpm: add unit test to tis-spi dan tan
2024-11-01 18:57 ` [PATCH v3 4/5] tpm/tpm_tis_spi: Support TPM for SPI (rev 3) dan tan
2024-11-01 18:57 ` [PATCH v3 5/5] tests/qtest/tpm: add unit test to tis-spi " dan tan
2024-11-01 19:25 ` Stefan Berger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0333d608-087e-4a8e-9937-7c97013a0bd4@linux.ibm.com \
    --to=stefanb@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=dantan@linux.vnet.ibm.com \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).