qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500
Date: Tue, 12 May 2015 12:05:58 +0300	[thread overview]
Message-ID: <034301d08c92$dccf6e80$966e4b80$@samsung.com> (raw)
In-Reply-To: <B5C21809C482C148A58516F588CD431466D281@szxeml557-mbx.china.huawei.com>

 Hello!

> I just pulled last git and git am-ed your patch on-top of my first 3 patches and got
this error:
> /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c: In function 'fdt_add_gic_node':
> /home/shlomo/qemu-new.git/qemu-64/hw/arm/virt.c:366:17: error:
> 'KVM_DEV_TYPE_ARM_VGIC_V3' undeclared (first use in this function)
>      if (type == KVM_DEV_TYPE_ARM_VGIC_V3) {

 Very strange. Check your source tree. This value is declared in
linux-headers/linux/kvm.h. Try to #include it directly maybe ? OTOH it perfectly works for
me, i have just verified, i have no extra #include's which could be missing from the
patch.
 But, may be something has changed in master over the last three days? Actually my base
tree is from friday.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

  reply	other threads:[~2015-05-12  9:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 13:09 [Qemu-devel] [PATCH v2] Add virt-v3 machine that uses GIC-500 Pavel Fedin
2015-05-11 11:30 ` Shlomo Pongratz
2015-05-12  9:05   ` Pavel Fedin [this message]
2015-05-12 11:29     ` Shlomo Pongratz
2015-05-12 12:33       ` Pavel Fedin
2015-05-13 10:34         ` Shlomo Pongratz
2015-05-13 13:57           ` Pavel Fedin
2015-05-14 12:01             ` Shlomo Pongratz
2015-05-14 15:27               ` Pavel Fedin
2015-05-12  9:11   ` Pavel Fedin
2015-05-12  9:20 ` Daniel P. Berrange
2015-05-12  9:32   ` Pavel Fedin
2015-05-12  9:56   ` Peter Maydell
2015-05-12 11:15     ` Pavel Fedin
2015-05-12 11:20       ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='034301d08c92$dccf6e80$966e4b80$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shlomo.pongratz@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).