From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag
Date: Tue, 4 Feb 2025 08:11:00 +0100 [thread overview]
Message-ID: <03497b94-e681-4bf7-8e1a-471d616219da@redhat.com> (raw)
In-Reply-To: <219be312-4acc-46c9-8a56-16e5cb483ae4@linaro.org>
On 26/11/2024 06.24, Philippe Mathieu-Daudé wrote:
> On 25/11/24 19:14, Philippe Mathieu-Daudé wrote:
>> Invert MachineClass 'no_sdcard' flag logic and rename it
>> to 'create_default_sdcard_drive' to make sense of this
>> default value applied to all machines. No logical change
>> intended.
>>
>> Philippe Mathieu-Daudé (3):
>> hw/boards: Convert no_sdcard flag to OnOffAuto tri-state
>> hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF
>> hw/boards: Rename no_sdcard -> create_default_sdcard_drive
Sorry, this felt through the cracks, but I think this series here is indeed
a much better idea than the code churn in your other series that simply
changes the bitfields into booleans.
> I expect next steps to be:
>
> - Remove nonsense create_default_sdcard_drive (where
> machines don't have SDHCI devices)
A fourth patch like this would be very welcome, too!
Thomas
prev parent reply other threads:[~2025-02-04 7:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 18:14 [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2024-11-25 18:14 ` [PATCH-for-10.0 1/3] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-04 6:59 ` Thomas Huth
2024-11-25 18:14 ` [PATCH-for-10.0 2/3] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-04 7:00 ` Thomas Huth
2024-11-25 18:14 ` [PATCH-for-10.0 3/3] hw/boards: Rename no_sdcard -> create_default_sdcard_drive Philippe Mathieu-Daudé
2025-02-04 7:07 ` Thomas Huth
2025-02-04 11:09 ` Philippe Mathieu-Daudé
2024-11-26 5:24 ` [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2025-02-04 7:11 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03497b94-e681-4bf7-8e1a-471d616219da@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).