From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MPNuo-0001gV-19
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 17:45:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MPNui-0001fF-HL
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 17:45:56 -0400
Received: from [199.232.76.173] (port=54201 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MPNui-0001fC-9T
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 17:45:52 -0400
Received: from mail-pz0-f175.google.com ([209.85.222.175]:55052)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <subhraveti@gmail.com>) id 1MPNuh-0000UJ-P7
	for qemu-devel@nongnu.org; Fri, 10 Jul 2009 17:45:51 -0400
Received: by pzk5 with SMTP id 5so103812pzk.4
	for <qemu-devel@nongnu.org>; Fri, 10 Jul 2009 14:45:50 -0700 (PDT)
Message-ID: <035301ca01a7$c90c4070$732d2b09@DineshThinkpad>
From: "Dinesh Subhraveti" <subhraveti@gmail.com>
References: <4A0C232D.1020201@wpkg.org>	<4A13CDC4.3000704@wpkg.org><4A1405E1.70405@wpkg.org>	<20090607040410.GA25831@amt.cnet>	<loom.20090709T005828-509@post.gmane.org>
	<h35lah$le7$1@ger.gmane.org> <4A56F9FD.5070208@siriusit.co.uk>
Subject: Re: [Qemu-devel] Re: [SOLUTION] "i8042.c: No controller found"	->OS
	sees no keyboard if I type "in BIOS"
Date: Fri, 10 Jul 2009 14:45:43 -0700
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=response
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>, qemu-devel@nongnu.org


> Dinesh Subhraveti wrote:
>
>> Sorry for the duplicate message above (mail server was taking hours to 
>> post, and I got impatient...)
>>
>> Changing PS2_QUEUE_SIZE to 15 and the "reserved space" to 8 fixes the 
>> problem for me:
>>
>> diff --git a/hw/ps2.c b/hw/ps2.c
>> index fb77005..51a3ab8 100644
>> --- a/hw/ps2.c
>> +++ b/hw/ps2.c
>> @@ -70,7 +70,7 @@
>>  #define MOUSE_STATUS_ENABLED    0x20
>>  #define MOUSE_STATUS_SCALE21    0x10
>>
>> -#define PS2_QUEUE_SIZE 256
>> +#define PS2_QUEUE_SIZE 15
>>
>>  typedef struct {
>>      uint8_t data[PS2_QUEUE_SIZE];
>> @@ -346,7 +346,7 @@ static void ps2_mouse_event(void *opaque,
>>      s->mouse_buttons = buttons_state;
>>
>>      if (!(s->mouse_status & MOUSE_STATUS_REMOTE) &&
>> -        (s->common.queue.count < (PS2_QUEUE_SIZE - 16))) {
>> +        (s->common.queue.count < (PS2_QUEUE_SIZE - 8))) {
>>          for(;;) {
>>              /* if not remote, send event. Multiple events are sent if
>>                 too big deltas */
>>
>> Both keyboard and mouse remain responsive after reboot, no matter how 
>> much I type / move the mouse during reboot.
>>
>> Any comments?
>
> Hi Dinesh,
>
> Thanks for this. I've applied this patch to the copy of kvm which hosts 
> our NT4 virtual which has been experiencing random mouse/keyboard input 
> problems. Fingers crossed that your patch will fix this issue for good...
>

Hi Mark,

I am not sure if this patch helps with the original issue you reported --  
random movements of the mouse.  If it does help, that's awesome, but I can't 
explain it.

It is only supposed to address OS not seeing the keyboard / mouse on reboot.

Does anyone see any problem with the above patch?

Thanks,
Dinesh Subhraveti