From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C43FC7EE23 for ; Wed, 31 May 2023 15:35:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4NqP-0002Lg-72; Wed, 31 May 2023 11:34:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4NqM-0002LO-Ov for qemu-devel@nongnu.org; Wed, 31 May 2023 11:34:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4NqI-0000zU-B0 for qemu-devel@nongnu.org; Wed, 31 May 2023 11:34:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685547265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=umgitms0WDA+J6n4PBGFnFBxJfVSSct62UU2xiE9bh8=; b=DJpahYJxogqPSBNj0Z6LpURo7ttAvtBEoT7upTheqJ16goM1gz32o8LRrcO45XXqR/WgbU IgAmyhTUDNqRkle1zH3E6gQeLVWnBgqF4uHFQD7BdYJME28bOj51Su4B967zpZTW1RqEHr QCoILtvWrKWkqhnFfGuoSOC9VChzh4o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-TkWelEWwM_CsuAHfJeV1hA-1; Wed, 31 May 2023 11:34:24 -0400 X-MC-Unique: TkWelEWwM_CsuAHfJeV1hA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f612a1b0fdso34312625e9.2 for ; Wed, 31 May 2023 08:34:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685547262; x=1688139262; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=umgitms0WDA+J6n4PBGFnFBxJfVSSct62UU2xiE9bh8=; b=lVN0PCnd+5pP3riqVNwlB21T88c8MPRBiFLKD1ty5DveOBGtyYSzL4JaiUvNqTmirc 5Dr/Qi/eQ7fL0BnQWZknjzPGYxn5QKHr9F7c2tBW23JAwCg4Jd2MiFahqQ85Kfaup84u JhwGHR0YESeBR4cczeZKlzFeq9aq+fNxew+di8ch1ZpocAlyAg8daZg5THpqcLGsvemj EQornwVwCIE+LxaSHRt4h8Gr2zUfScOclpl8XO3I5dPeu9tj+rGgSEgUdsG8UZiPNu4q ykroSzunc6ctxm1+CclQvkpe6K6ScL2vt6qfvmGM8751vnHUDReudLBM+POB/ms2yPTI /Lqg== X-Gm-Message-State: AC+VfDzrns+9oMp40J6TcVDydDBHK2NtZbPvd8X5N7y133rBBBPn37iY mGRCJFqbiWvnuKqV9GwlODqf4kNIqVq1f7sMXG2Q0Do5ZwyEOSurrMQuQp9oj2QS+pqyTxcSvnz IOIZWA5O6BbgbWQk= X-Received: by 2002:a5d:5083:0:b0:304:b967:956f with SMTP id a3-20020a5d5083000000b00304b967956fmr5865098wrt.8.1685547262114; Wed, 31 May 2023 08:34:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5qmRLaAjOTsTojZd4boW8sMOfJa3tWYmjYWLPBbJmPnX6Ii4n9FuX2unlbdZTYzRDECgLPjA== X-Received: by 2002:a5d:5083:0:b0:304:b967:956f with SMTP id a3-20020a5d5083000000b00304b967956fmr5865082wrt.8.1685547261861; Wed, 31 May 2023 08:34:21 -0700 (PDT) Received: from [192.168.0.3] (ip-109-43-178-4.web.vodafone.de. [109.43.178.4]) by smtp.gmail.com with ESMTPSA id l16-20020adffe90000000b0030ae93bd196sm7173571wrr.21.2023.05.31.08.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 08:34:21 -0700 (PDT) Message-ID: <035823a1-e5f9-0f4c-9732-d69a39cdef93@redhat.com> Date: Wed, 31 May 2023 17:34:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] meson.build: Use -Wno-undef only for SDL 2.0.8 and older Content-Language: en-US From: Thomas Huth To: Paolo Bonzini , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-trivial@nongnu.org References: <20230531093902.70695-1-thuth@redhat.com> In-Reply-To: <20230531093902.70695-1-thuth@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.163, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.091, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 31/05/2023 11.39, Thomas Huth wrote: > There is no need to disable this useful compiler warning for > newer versions of the SDL anymore. > > This also enables the printing of the version number with > newer versions of the SDL in the summary of the meson output > again. > > Signed-off-by: Thomas Huth > --- > meson.build | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/meson.build b/meson.build > index bc76ea96bf..8ccd928dca 100644 > --- a/meson.build > +++ b/meson.build > @@ -1273,10 +1273,12 @@ if not get_option('sdl').auto() or have_system > sdl_image = not_found > endif > if sdl.found() > - # work around 2.0.8 bug > - sdl = declare_dependency(compile_args: '-Wno-undef', > - dependencies: sdl, > - version: sdl.version()) > + if sdl.version().version_compare('<=2.0.8') > + # work around 2.0.8 bug > + sdl = declare_dependency(compile_args: '-Wno-undef', > + dependencies: sdl, > + version: sdl.version()) > + endif Drat, never mind, this still fails with the SDL2 from MinGW: https://gitlab.com/thuth/qemu/-/jobs/4385862312#L3048 Thomas