Re: [Qemu-devel] [PULL 11/29] target/riscv: Convert RV32F insns to decodetree

Re: [Qemu-devel] [PULL 11/29] target/riscv: Convert RV32F insns to decodetree

[Philippe Mathieu-Daudé]

Hi Palmer, Bastian,

(old patch)

On 12/3/19 14:15, Palmer Dabbelt wrote:
> From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> 
> Acked-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
> ---
>   target/riscv/insn32.decode              |  35 +++
>   target/riscv/insn_trans/trans_rvf.inc.c | 379 ++++++++++++++++++++++++
>   target/riscv/translate.c                |   1 +
>   3 files changed, 415 insertions(+)
>   create mode 100644 target/riscv/insn_trans/trans_rvf.inc.c


> +static bool trans_fmv_x_w(DisasContext *ctx, arg_fmv_x_w *a)
> +{
> +    /* NOTE: This was FMV.X.S in an earlier version of the ISA spec! */
> +    REQUIRE_FPU;
> +    REQUIRE_EXT(ctx, RVF);
> +
> +    TCGv t0 = tcg_temp_new();
> +
> +#if defined(TARGET_RISCV64)

Just noticed this while reviewing Richard's "tcg: Remove tcg_const_*'
recent series, shouldn't be this #if condition inverted?

> +    tcg_gen_ext32s_tl(t0, cpu_fpr[a->rs1]);
> +#else
> +    tcg_gen_extrl_i64_i32(t0, cpu_fpr[a->rs1]);
> +#endif
> +
> +    gen_set_gpr(a->rd, t0);
> +    tcg_temp_free(t0);
> +
> +    return true;
> +}

Re: [Qemu-devel] [PULL 11/29] target/riscv: Convert RV32F insns to decodetree

[Richard Henderson]

On 3/6/23 06:11, Philippe Mathieu-Daudé wrote:
> Hi Palmer, Bastian,
> 
> (old patch)
> 
> On 12/3/19 14:15, Palmer Dabbelt wrote:
>> From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>>
>> Acked-by: Alistair Francis <alistair.francis@wdc.com>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
>> Signed-off-by: Peer Adelt <peer.adelt@hni.uni-paderborn.de>
>> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
>> ---
>>   target/riscv/insn32.decode              |  35 +++
>>   target/riscv/insn_trans/trans_rvf.inc.c | 379 ++++++++++++++++++++++++
>>   target/riscv/translate.c                |   1 +
>>   3 files changed, 415 insertions(+)
>>   create mode 100644 target/riscv/insn_trans/trans_rvf.inc.c
> 
> 
>> +static bool trans_fmv_x_w(DisasContext *ctx, arg_fmv_x_w *a)
>> +{
>> +    /* NOTE: This was FMV.X.S in an earlier version of the ISA spec! */
>> +    REQUIRE_FPU;
>> +    REQUIRE_EXT(ctx, RVF);
>> +
>> +    TCGv t0 = tcg_temp_new();
>> +
>> +#if defined(TARGET_RISCV64)
> 
> Just noticed this while reviewing Richard's "tcg: Remove tcg_const_*'
> recent series, shouldn't be this #if condition inverted?

No, you'd notice the compile error straight away.

r~

> 
>> +    tcg_gen_ext32s_tl(t0, cpu_fpr[a->rs1]);
>> +#else
>> +    tcg_gen_extrl_i64_i32(t0, cpu_fpr[a->rs1]);
>> +#endif
>> +
>> +    gen_set_gpr(a->rd, t0);
>> +    tcg_temp_free(t0);
>> +
>> +    return true;
>> +}
> 
>