From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: P J P <ppandit@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Arash TC" <tohidi.arash@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] ccid-card-passthru: check buffer size parameter
Date: Thu, 11 Oct 2018 14:38:57 +0200 [thread overview]
Message-ID: <0373c040-df0f-0c22-4e85-227e1d51749f@redhat.com> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1810111749490.9486@xnncv>
On 11/10/2018 14:29, P J P wrote:
> +-- On Thu, 11 Oct 2018, Philippe Mathieu-Daudé wrote --+
> | The IOReadHandler does not have documentation.
> |
> | typedef void IOReadHandler(void *opaque, const uint8_t *buf, int size);
> |
> | Why is the 'size' argument signed? Does it makes sens to call it with a
> | negative value?
>
> No, it doesn't IMO. I had first changed argument type 'int' to uint32_t'.
> as
>
> typedef void IOReadHandler(void *opaque, const uint8_t *buf, uint32_t size);
>
> But 'IOReadHandler' is registered and called from multiple char devices,
> which lead to compile time errors. As the function prototype changed.
>
> I'll update them all, if the above change is okay.
I started this change and already converted 40 files.
next prev parent reply other threads:[~2018-10-11 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 11:24 [Qemu-devel] [PATCH] ccid-card-passthru: check buffer size parameter P J P
2018-10-11 11:58 ` Philippe Mathieu-Daudé
2018-10-11 12:15 ` Paolo Bonzini
2018-10-11 12:29 ` P J P
2018-10-11 12:34 ` Paolo Bonzini
2018-10-11 12:38 ` Philippe Mathieu-Daudé [this message]
2018-10-11 12:50 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0373c040-df0f-0c22-4e85-227e1d51749f@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tohidi.arash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).