From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Fabiano Rosas <farosas@linux.ibm.com>, qemu-devel@nongnu.org
Cc: eduardo@habkost.net, crosa@redhat.com
Subject: Re: [PATCH] analyze-migration.py: Fix instance_id signedness
Date: Mon, 21 Feb 2022 19:47:43 +0100 [thread overview]
Message-ID: <0375cd23-a30b-1647-e7ce-033ce8e9ef3f@gmail.com> (raw)
In-Reply-To: <20220221175357.2103775-1-farosas@linux.ibm.com>
On 21/2/22 18:53, Fabiano Rosas wrote:
> The instance_id field is uint32_t in the migration code, however the
> script currently handles it as a signed integer:
>
> $ ./scripts/analyze-migration.py -f mig
> Traceback (most recent call last):
> File "./scripts/analyze-migration.py", line 605, in <module>
> dump.read(dump_memory = args.memory)
> File "./scripts/analyze-migration.py", line 539, in read
> classdesc = self.section_classes[section_key]
> KeyError: ('spapr_iommu', -2147483648)
>
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
> ---
> scripts/analyze-migration.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
prev parent reply other threads:[~2022-02-21 18:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 17:53 [PATCH] analyze-migration.py: Fix instance_id signedness Fabiano Rosas
2022-02-21 18:47 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0375cd23-a30b-1647-e7ce-033ce8e9ef3f@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=crosa@redhat.com \
--cc=eduardo@habkost.net \
--cc=farosas@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).