From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyWeN-0006XL-P8 for qemu-devel@nongnu.org; Wed, 21 Mar 2018 01:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyWeI-0001pc-Tc for qemu-devel@nongnu.org; Wed, 21 Mar 2018 01:51:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41382 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyWeI-0001of-OL for qemu-devel@nongnu.org; Wed, 21 Mar 2018 01:50:58 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A0A8412A020 for ; Wed, 21 Mar 2018 05:50:52 +0000 (UTC) References: <20180320151857.26340-1-pbonzini@redhat.com> <20180321032547.GB20227@xz-mi> From: Paolo Bonzini Message-ID: <0378f258-f357-5fb9-b98f-8dd5d95b8db9@redhat.com> Date: Wed, 21 Mar 2018 06:50:46 +0100 MIME-Version: 1.0 In-Reply-To: <20180321032547.GB20227@xz-mi> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] chardev-socket: remove useless if List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org On 21/03/2018 04:25, Peter Xu wrote: > On Tue, Mar 20, 2018 at 04:18:57PM +0100, Paolo Bonzini wrote: >> This trips Coverity, which believes the subsequent qio_channel_create_watch >> can dereference a NULL pointer. In reality, tcp_chr_connect's callers >> all have s->ioc properly initialized, since they are all rooted at >> tcp_chr_new_client. >> >> Signed-off-by: Paolo Bonzini > > (maybe replacing with an assertion would be nicer? No big deal.) It's already asserting, it just raises SIGSEGV instead of SIGABRT. :) Paolo