Re: [PATCH v2 1/5] hw/sd: add nuvoton MMC

[Richard Henderson <richard.henderson@linaro.org>]

On 11/1/21 1:18 PM, Peter Maydell wrote:
> On Fri, 8 Oct 2021 at 01:26, Hao Wu <wuhaotsh@google.com> wrote:
>>
>> From: Shengtan Mao <stmao@google.com>
>>
>> Signed-off-by: Shengtan Mao <stmao@google.com>
>> Reviewed-by: Hao Wu <wuhaotsh@google.com>
>> Reviewed-by: Chris Rauer <crauer@google.com>
>> Reviewed-by: Tyrone Ting <kfting@nuvoton.com>
>> Signed-off-by:  Hao Wu <wuhaotsh@google.com>
>> ---
> 
>> +    default:
>> +        qemu_log_mask(LOG_GUEST_ERROR, "SDHCI read of nonexist reg: 0x%02"
> 
> "nonexistent"
> 
>> +                      HWADDR_PRIx, addr);
>> +        break;
>> +    }
>> +
>> +    return val;
>> +}
>> +
>> +static void npcm7xx_sdhci_write(void *opaque, hwaddr addr, uint64_t val,
>> +                                unsigned int size)
>> +{
>> +    NPCM7xxSDHCIState *s = opaque;
>> +
>> +    switch (addr) {
>> +    case NPCM7XX_BOOTTOCTRL:
>> +        s->regs.boottoctrl = val;
>> +        break;
>> +    default:
>> +        qemu_log_mask(LOG_GUEST_ERROR, "SDHCI write of nonexist reg: 0x%02"
> 
> ditto

Fixed while applying.


r~