From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Ani Sinha <anisinha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] kvm/i386: refactor kvm_arch_init and split it into smaller functions
Date: Tue, 3 Sep 2024 15:15:36 +0200 [thread overview]
Message-ID: <0388418e-ad94-43fa-a375-73cbff27a2e4@linaro.org> (raw)
In-Reply-To: <20240903113418.38475-1-anisinha@redhat.com>
On 3/9/24 13:34, Ani Sinha wrote:
> kvm_arch_init() enables a lot of vm capabilities. Refactor them into separate
> smaller functions. Energy MSR related operations also moved to its own
> function. There should be no functional impact.
>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> target/i386/kvm/kvm.c | 337 ++++++++++++++++++++++++++----------------
> 1 file changed, 211 insertions(+), 126 deletions(-)
Nice cleanup, however it would be easier to review as a series
of dumb "extract FOO function" patches instead of a single one.
Up to the maintainer.
prev parent reply other threads:[~2024-09-03 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:34 [PATCH] kvm/i386: refactor kvm_arch_init and split it into smaller functions Ani Sinha
2024-09-03 13:15 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0388418e-ad94-43fa-a375-73cbff27a2e4@linaro.org \
--to=philmd@linaro.org \
--cc=anisinha@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).