From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AC63C02181 for ; Fri, 24 Jan 2025 17:41:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tbNfG-0003Zd-EK; Fri, 24 Jan 2025 12:40:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tbNfA-0003X7-Vh for qemu-devel@nongnu.org; Fri, 24 Jan 2025 12:40:13 -0500 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tbNf9-0002oP-2T for qemu-devel@nongnu.org; Fri, 24 Jan 2025 12:40:12 -0500 Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-6dd1b895541so47015526d6.0 for ; Fri, 24 Jan 2025 09:40:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1737740410; x=1738345210; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=whu1tYPX1DIKsEnegp1oH1/XFqeOkSpePtst4qKd65c=; b=iUSOScLxsS9vdff47pKFjOPMwA2V0zrYo/1KVaTNtOTjT/g8Af1h9/jP1Au2BSmopZ LQ+666hCUYzdqs8TYmt5M00UERvXVQIOsGEuxTArQ2ibwFALFhFyzefCAkEoe9OGTQNy o9b/3yfqHWpFdi0JKFeuUHSDuSmpm0/NfhiKcBdQ8Z/rgb/ZxvUnDKowWjx4rFu0MsI8 gSZPIH1/PofipD/8saYyiPwaS6bS2RFypwlELqBqfCuuDaQOReTKdnr0DlOUbPodvLlM fPh0sU4qnKZi+RiCJUuLR0/pSi6xwHdA7h27VBs05ztsbY5mpM6U/t3GDN+TFKzG1A7A kEJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737740410; x=1738345210; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=whu1tYPX1DIKsEnegp1oH1/XFqeOkSpePtst4qKd65c=; b=hIR0vqhogU35cuGBTMUgAmvBMzc7gpSp5nkvDxe0Hqx43alKqbrBU+itmnf8xUKPNE YRsIsaDUQb37yyBnwBf/0ksqYwwpFDovu/V3pk3SPcikKz6j8Fn6E0lgiYPmZ7x3ftKY ZHmoVlhbF/fM/FchsjTIA0Ozaaod+0kHGS8eq6mvOX2qzFjXDeiVE6eybi2HvjJjq9vc WDc5fiTSwkcUmkaGIurJLcVU5Uu2r5WymNJpwi2j0XsGElX3I3utPiiOaw9mMxGVxlXE krtuWenWS4mOj6fSbPAztnYHnzXEZLi1Shx4psifeISv9bZ2uq5FpooH30rV4KBzufot ojsA== X-Forwarded-Encrypted: i=1; AJvYcCXYFqdUyg96/tKmJaAPK4M/XMq7DaDgK2PG6RTvCFBOMKA5X2HbPj0eUvS2BY87maTjQ3Ai0kKH3Jyp@nongnu.org X-Gm-Message-State: AOJu0YxL2omcH4Zug4pp1hycwVf77m5v2BT9onvbSKBUFgpaEhNWOn54 CvmdYA13RW/Ba3FDnWe8WYyt7RuRGNeMYYV9X7M4m9IMwy7mKTq+e0xMvjaefVs= X-Gm-Gg: ASbGnctqrn4Y0IPFgFhb3qOvD0sjBteU53a1zUT27W+j4wiUwJcbVMU6BMqrkxYGWW2 Xok/mGC1e215qpKNqXeGMpw4BBdHm+xnvxVhcO6hJUqTFRc+gMsE+91EBQ2o7b7ZYGeRs2nVRbp j5Wn1Ifph7mADfjcW6oUc8HtvIrnCkjxJl/ggcKPQp9va/AgbmnFH5jjwvPP9V/fvlIuv+3FAks w8CvUaXE55TIbWHeZDPhoptY9m32aC0Z3DDd2JG5h5E2z9oG3ROq4gpheF2yQqHDzBn0JmoMQYk 1lUxCL8rfLGMuCULS1aGAktXon6yuLqTbLkvvDcnsfn48jREgdQ4DC9gEcUN8A44mw== X-Google-Smtp-Source: AGHT+IE4fTXG1rvgr48gCctvowJzj5i4rpqlAyHTIHit0ZkMb3GGR+HaA5QQwTJuji06wDa9PYnRFQ== X-Received: by 2002:a05:6214:29ea:b0:6d8:932a:eaa3 with SMTP id 6a1803df08f44-6e1b216ef63mr483487356d6.3.1737740409823; Fri, 24 Jan 2025 09:40:09 -0800 (PST) Received: from ?IPV6:2607:fb90:c9e1:9829:9eed:533c:6788:9f4a? ([2607:fb90:c9e1:9829:9eed:533c:6788:9f4a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6e2058c2164sm10442886d6.99.2025.01.24.09.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jan 2025 09:40:09 -0800 (PST) Message-ID: <038f15ee-73bd-4b44-87e7-fc3086562814@linaro.org> Date: Fri, 24 Jan 2025 09:40:06 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 28/28] cpus: Remove CPUClass::has_work() handler To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-s390x@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, Paolo Bonzini References: <20250121142341.17001-1-philmd@linaro.org> <20250121142341.17001-29-philmd@linaro.org> Content-Language: en-US From: Richard Henderson In-Reply-To: <20250121142341.17001-29-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=richard.henderson@linaro.org; helo=mail-qv1-xf35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/21/25 06:23, Philippe Mathieu-Daudé wrote: > diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c > index 7b16bda2250..7f287984aa6 100644 > --- a/hw/core/cpu-system.c > +++ b/hw/core/cpu-system.c > @@ -25,12 +25,8 @@ > > bool cpu_has_work(CPUState *cpu) > { > - if (cpu->cc->sysemu_ops->has_work) { > - return cpu->cc->sysemu_ops->has_work(cpu); > - } > - > - g_assert(cpu->cc->has_work); > - return cpu->cc->has_work(cpu); > + g_assert(cpu->cc->sysemu_ops->has_work); > + return cpu->cc->sysemu_ops->has_work(cpu); Let's assert this once at startup, much like we do in tcg_exec_realizefn for TCGCPUOps. Otherwise, Reviewed-by: Richard Henderson r~