qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Claudio Fontana <cfontana@suse.de>,
	qemu-devel@nongnu.org,
	Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH] disas: Remove libvixl disassembler
Date: Thu, 9 Jun 2022 10:47:24 +0200	[thread overview]
Message-ID: <03a1e04e-45c7-5002-6920-d04e29fd48fd@redhat.com> (raw)
In-Reply-To: <7ae17984-89c4-2247-57a7-fde6206e41e0@redhat.com>

On 08/06/2022 17.51, Paolo Bonzini wrote:
> On 6/3/22 19:35, Thomas Huth wrote:
>> On 03/06/2022 19.26, Claudio Fontana wrote:
>>> On 6/3/22 18:42, Thomas Huth wrote:
>>>> The disassembly via capstone should be superiour to our old vixl
>>>> sources nowadays, so let's finally cut this old disassembler out
>>>> of the QEMU source tree.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>
>>> agreed, one thought: at the time I added this thing, I had to add C++ 
>>> compilation support,
>>> maybe something we can now drop if there are no more C++ users?
>>
>> I thought about that, too, but we still have disas/nanomips.cpp left and 
>> the Windows-related files in qga/vss-win32/* .
> 
> That is pure C++ so it does not need the extra complication of "detect 
> whether the C and C++ compiler are ABI-compatible" (typically due to 
> different libasan/libtsan implementation between gcc and clang).  So it's 
> really just nanoMIPS that's left.

Ok, so the next theoretical question is: If we get rid of the nanomips.cpp 
file or convert it to plain C, would we then simplify the code in configure 
again (and forbid C++ for the main QEMU code), or would we rather keep the 
current settings in case we want to re-introduce more C++ code again in the 
future?

  Thomas



  reply	other threads:[~2022-06-09  8:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 16:42 [PATCH] disas: Remove libvixl disassembler Thomas Huth
2022-06-03 17:06 ` Richard Henderson
2022-06-03 17:26 ` Claudio Fontana
2022-06-03 17:35   ` Thomas Huth
2022-06-08 15:51     ` Paolo Bonzini
2022-06-09  8:47       ` Thomas Huth [this message]
2022-06-09  8:57         ` Daniel P. Berrangé
2022-06-09 11:27           ` Claudio Fontana
2022-06-09 14:15             ` Claudio Fontana
2022-06-09 14:34               ` What to do with the nanomips disassembler (was: [PATCH] disas: Remove libvixl disassembler) Thomas Huth
2022-06-09 16:31                 ` Vince Del Vecchio via
2022-06-09 17:36                   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03a1e04e-45c7-5002-6920-d04e29fd48fd@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cfontana@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).