From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1HtW-0006SH-9F for qemu-devel@nongnu.org; Mon, 31 Oct 2016 15:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1HtS-0006WM-F3 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 15:05:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1HtS-0006W1-7c for qemu-devel@nongnu.org; Mon, 31 Oct 2016 15:05:14 -0400 References: <1477723631-8700-1-git-send-email-ashish.mittal@veritas.com> From: Eric Blake Message-ID: <03bd59d7-8aae-9448-11ab-3b1f4accd008@redhat.com> Date: Mon, 31 Oct 2016 14:05:11 -0500 MIME-Version: 1.0 In-Reply-To: <1477723631-8700-1-git-send-email-ashish.mittal@veritas.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QEckIdBp34EArnfg501XJ9DD0mrenKFF5" Subject: Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs". List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashish Mittal , qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com Cc: Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QEckIdBp34EArnfg501XJ9DD0mrenKFF5 From: Eric Blake To: Ashish Mittal , qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, stefanha@gmail.com, Rakesh.Ranjan@veritas.com, Buddhi.Madhav@veritas.com Cc: Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com, Venkatesha.Mg@veritas.com Message-ID: <03bd59d7-8aae-9448-11ab-3b1f4accd008@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4] This patch adds support for a new block device type called "vxhs". References: <1477723631-8700-1-git-send-email-ashish.mittal@veritas.com> In-Reply-To: <1477723631-8700-1-git-send-email-ashish.mittal@veritas.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/29/2016 01:47 AM, Ashish Mittal wrote: > Source code for the qnio library that this code loads can be downloaded= from: > https://github.com/MittalAshish/libqnio.git For now, just an interface review: >=20 > Sample command line using the JSON syntax: > ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us= > -vga cirrus -device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D= 0x5 > -msg timestamp=3Don > 'json:{"driver":"vxhs","vdisk_id":"c3e9095a-a5ee-4dce-afeb-2a59fb387410= ", This doesn't match the code, which spelled it "vdisk-id". > "server":{"host":"172.172.17.4","port":"9999"}}' >=20 > Sample command line using the URI syntax: > qemu-img convert -f raw -O raw -n > /var/lib/nova/instances/_base/0c5eacd5ebea5ed914b6a3e7b18f1ce734c386ad > vxhs://192.168.0.1:9999/c6718f6b-0401-441d-a8c3-1f0064d75ee0 >=20 > Signed-off-by: Ashish Mittal > --- > +++ b/qapi/block-core.json > @@ -1704,12 +1704,13 @@ > # @host_device, @host_cdrom: Since 2.1 > # @gluster: Since 2.7 > # @nbd: Since 2.8 > +# @vxhs: Since 2.8 Please rebase on top of the latest block pull request: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg08089.html In particular, your patch should look something like: -# @nbd, @nfs, @replication, @ssh: Since 2.8 +# @nbd, @nfs, @replication, @ssh, @vxhs: Since 2.8 > # > # Since: 2.0 > ## > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > - 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', > + 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', 'vx= hs', > 'host_device', 'http', 'https', 'luks', 'nbd', 'null-aio',= > 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', = 'raw', > 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfa= t' ] } Please keep this enum sorted alphabetically (your entry should be after vvfat, not in the random middle). > @@ -2238,6 +2239,20 @@ > '*export': 'str', > '*tls-creds': 'str' } } > =20 > +# @BlockdevOptionsVxHS Missing a leading ## marker. > +# > +# Driver specific block device options for VxHS > +# > +# @vdisk-id: UUID of VxHS volume > +# > +# @server: vxhs server IP, port > +# > +# Since: 2.8 > +## > +{ 'struct': 'BlockdevOptionsVxHS', > + 'data': { 'vdisk-id': 'str', > + 'server': 'InetSocketAddress' } } > + > ## > # @BlockdevOptions > # > @@ -2302,7 +2317,8 @@ > 'vhdx': 'BlockdevOptionsGenericFormat', > 'vmdk': 'BlockdevOptionsGenericCOWFormat', > 'vpc': 'BlockdevOptionsGenericFormat', > - 'vvfat': 'BlockdevOptionsVVFAT' > + 'vvfat': 'BlockdevOptionsVVFAT', > + 'vxhs': 'BlockdevOptionsVxHS' > } } > =20 > ## >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QEckIdBp34EArnfg501XJ9DD0mrenKFF5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYF5XnAAoJEKeha0olJ0Nq4f0H/j83EKxwh7A83Ko+P7ZvWWid fDeSOLw3lzSQ0eRV7+fnFpo/wdSS3KbV7Pmq+EdYrFnrp5G6pyyhk8WJGuFcA6g7 EutOBcPd6p+ZeAN7JKljQhF2tQ830J9uEHdf5xhW3xG0hiebVERQ3sOx7lEdmHuO anzvnoyrBSAej5RmiL75EOjlJ+s2w4x9GrzDocrKr6O+HAbSkOktQb8+YKZdDYd0 2IKTqmuUBiUDNXQeYY8VnsDdq8uKtzPmBo3LMw6B0pcnbR3fKmAh+S/htkd+MeP4 Vna7VIV8HxXOPSpopAkrhnXg7cV5Qe9tnX/kjTqWN6BI2qFxSFqPQaOF6R++dG8= =h/9W -----END PGP SIGNATURE----- --QEckIdBp34EArnfg501XJ9DD0mrenKFF5--