qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Klaus Jensen <its@irrelevant.dk>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Keith Busch <kbusch@kernel.org>,
	qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>
Subject: Re: [PATCH 1/2] hw/nvme: fix memory leak in fdp ruhid parsing
Date: Wed, 12 Apr 2023 11:47:57 +0200	[thread overview]
Message-ID: <03c52495-d40e-3e67-c564-6f1a5400e5a4@linaro.org> (raw)
In-Reply-To: <20230411190448.64863-2-its@irrelevant.dk>

On 11/4/23 21:04, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> Coverity reports a memory leak of memory when parsing ruhids at
> namespace initialization. Since this is just working memory, not needed
> beyond the scope of the functions, fix this by adding a g_autofree
> annotation.
> 
> Reported-by: Coverity (CID 1507979)
> Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation")
> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
> ---
>   hw/nvme/ns.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2023-04-12  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 19:04 [PATCH 0/2] hw/nvme: coverity fixes Klaus Jensen
2023-04-11 19:04 ` [PATCH 1/2] hw/nvme: fix memory leak in fdp ruhid parsing Klaus Jensen
2023-04-12  9:47   ` Philippe Mathieu-Daudé [this message]
2023-04-11 19:04 ` [PATCH 2/2] hw/nvme: fix memory leak in nvme_dsm Klaus Jensen
2023-04-12  9:54   ` Philippe Mathieu-Daudé
2023-04-12 10:02     ` Klaus Jensen
2023-04-12  9:40 ` [PATCH 0/2] hw/nvme: coverity fixes Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03c52495-d40e-3e67-c564-6f1a5400e5a4@linaro.org \
    --to=philmd@linaro.org \
    --cc=its@irrelevant.dk \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).