From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFOcl-0002Dp-AN
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:34:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFOcf-00052f-0x
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:34:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36529)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bFOce-00052b-Rx
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 12:33:56 -0400
References: <20160618040343.19517-1-bobby.prani@gmail.com>
	<20160618040343.19517-15-bobby.prani@gmail.com>
	<06f042ba-91b2-d751-e53e-6e5ca56081d3@redhat.com>
	<108160aa-0789-67aa-cc42-01e4332b3581@twiddle.net>
	<7e333754-9755-dda5-143e-5a0c41ab9608@redhat.com>
	<daffe833-9d77-3dbe-8e73-ee06f892cfbc@twiddle.net>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <03c5b5ea-fc8c-e1b6-29bc-cc03417fc77d@redhat.com>
Date: Tue, 21 Jun 2016 18:33:51 +0200
MIME-Version: 1.0
In-Reply-To: <daffe833-9d77-3dbe-8e73-ee06f892cfbc@twiddle.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v3 PATCH 14/14] target-i386: Generate fences
 for x86
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, Pranith Kumar <bobby.prani@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, "open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: serge.fdrv@gmail.com, alex.bennee@linaro.org



On 21/06/2016 18:23, Richard Henderson wrote:
> On 06/21/2016 09:12 AM, Paolo Bonzini wrote:
>>
>>
>> On 21/06/2016 17:57, Richard Henderson wrote:
>>>>>
>>>>>                  || (prefixes & PREFIX_LOCK)) {
>>>>>                  goto illegal_op;
>>>>>              }
>>>>> +            tcg_gen_mb(TCG_MO_ST_ST | TCG_BAR_SC);
>>>>>              break;
>>>>>          case 0xe8 ... 0xef: /* lfence */
>>>>> +            tcg_gen_mb(TCG_MO_LD_LD | TCG_BAR_SC);
>>>>> +            break;
>>>>
>>>> These are unnecessary.  On the other hand, _each and every load_
>>>> must be
>>>> followed by a LD_LD | LD_ST barrier, and each and every store must be
>>>> preceded by a LD_ST | ST_ST barrier.
>>>
>>> They're not unnecessary if we (1) add those barriers for normal loads
>>> and stores and (2) omit them from the non-temporal loads and stores.
>>
>> When does TCG generate non-temporal loads and stores?
> 
> I was talking about the guest non-temporal loads and stores.

Oh, you're right---sorry, I confused target-i386 and tcg/i386.

Thanks,

Paolo