From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers
Date: Fri, 20 Oct 2017 12:37:20 +0200 [thread overview]
Message-ID: <03c6bfa2-77b1-8ab6-482b-466aa2ac96b7@redhat.com> (raw)
In-Reply-To: <1b56a63f-ab38-219b-6b2c-2a43c343e5f0@redhat.com>
On 20/10/2017 12:27, Laszlo Ersek wrote:
>> +if compile_object "-Werror" "" ; then
>> + :
>> +else
> Is this an established idiom for the configure script, in place of:
>
> if ! compile_object "-Werror" "" ; then
>
> ?
>
> Looks good to me otherwise.
I tend not use "if !". In general that's just me, but in this case I
think it's useful to point out that a successful compile does nothing;
generally it's the successful compile that adjusts command line arguments.
Paolo
next prev parent reply other threads:[~2017-10-20 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 10:12 [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers Paolo Bonzini
2017-10-20 10:27 ` Laszlo Ersek
2017-10-20 10:37 ` Paolo Bonzini [this message]
2017-10-20 10:45 ` Laszlo Ersek
2017-10-20 10:48 ` Peter Maydell
2017-10-20 11:02 ` Paolo Bonzini
2017-10-20 15:08 ` Laszlo Ersek
2017-10-20 15:09 ` Paolo Bonzini
2017-10-20 15:32 ` Laszlo Ersek
2017-10-20 15:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c6bfa2-77b1-8ab6-482b-466aa2ac96b7@redhat.com \
--to=pbonzini@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).