From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB44EC433E6 for ; Tue, 2 Mar 2021 08:20:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69B5E64DE7 for ; Tue, 2 Mar 2021 08:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69B5E64DE7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH0G7-0008ME-Da for qemu-devel@archiver.kernel.org; Tue, 02 Mar 2021 03:19:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH0F6-0007TS-9b for qemu-devel@nongnu.org; Tue, 02 Mar 2021 03:18:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:57968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH0F4-0003iF-Kp for qemu-devel@nongnu.org; Tue, 02 Mar 2021 03:18:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0EE57AC24; Tue, 2 Mar 2021 08:18:53 +0000 (UTC) Subject: Re: [RFC v2 14/24] target/arm: split vfp state setting from tcg helpers To: Richard Henderson References: <20210301164936.19446-1-cfontana@suse.de> <20210301164936.19446-15-cfontana@suse.de> <3658a432-7dc1-ce34-e341-710ea6013556@linaro.org> From: Claudio Fontana Message-ID: <03d6abf6-e076-17d9-d23a-5dd00bc4540e@suse.de> Date: Tue, 2 Mar 2021 09:18:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <3658a432-7dc1-ce34-e341-710ea6013556@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/2/21 5:24 AM, Richard Henderson wrote: > On 3/1/21 8:49 AM, Claudio Fontana wrote: >> vfp_get_fpsr and vfp_set_fpsr are needed also for KVM. >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/cpu-vfp.h | 29 +++++ >> target/arm/cpu-vfp.c | 92 +++++++++++++++ >> target/arm/kvm/helper-stubs.c | 10 ++ >> target/arm/tcg/cpu-vfp.c | 146 +++++++++++++++++++++++ >> target/arm/tcg/vfp_helper.c | 210 +--------------------------------- >> target/arm/meson.build | 1 + >> target/arm/tcg/meson.build | 1 + >> 7 files changed, 281 insertions(+), 208 deletions(-) >> create mode 100644 target/arm/cpu-vfp.h >> create mode 100644 target/arm/cpu-vfp.c >> create mode 100644 target/arm/tcg/cpu-vfp.c > > kvm/helper-stubs.c should be for all !tcg. > > > r~ > Can you explain more what you mean? In this patch kvm/helper-stubs.c is updated to include two stubs: uint32_t vfp_get_fpscr_from_host(CPUARMState *env) { return 0; } void vfp_set_fpscr_to_host(CPUARMState *env, uint32_t val) { } The corresponding tcg code instead is in tcg/arm/cpu-vtp.c. For the non-stub code that comprises vfp_get_fpscr vfp_set_fpscr the code is moved to target/arm/cpu-vfp.c, to be shared by tcg and kvm. Thanks, C