From: <ltaylorsimpson@gmail.com>
To: "'Matheus Tavares Bernardino'" <quic_mathbern@quicinc.com>,
<qemu-devel@nongnu.org>
Cc: <bcain@quicinc.com>, <sidneym@quicinc.com>, <ale@rev.ng>, <anjo@rev.ng>
Subject: RE: [PATCH] Hexagon: fix F2_conv_* instructions for negative zero
Date: Mon, 29 Jul 2024 12:51:14 -0600 [thread overview]
Message-ID: <03df01dae1e8$49f42410$dddc6c30$@gmail.com> (raw)
In-Reply-To: <9f3be6911db2dcff834ce6b530118fa383b9e46a.1722186937.git.quic_mathbern@quicinc.com>
> -----Original Message-----
> From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Sent: Sunday, July 28, 2024 11:16 AM
> To: qemu-devel@nongnu.org
> Cc: ltaylorsimpson@gmail.com; bcain@quicinc.com; sidneym@quicinc.com;
> ale@rev.ng; anjo@rev.ng
> Subject: [PATCH] Hexagon: fix F2_conv_* instructions for negative zero
>
> The implementation for these instructions handles -0 as an invalid float
point
> value, whereas the Hexagon hardware considers it the same as +0 (which is
> valid). Let's fix that and add a regression test.
>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> ---
> target/hexagon/op_helper.c | 16 ++++++++--------
> tests/tcg/hexagon/usr.c | 10 ++++++++++
> 2 files changed, 18 insertions(+), 8 deletions(-)
You should update the copyright year to 2024 in the files you changed.
Otherwise
Reviewed-by: Taylor Simpson <ltaylorsimpson@gmail.com>
prev parent reply other threads:[~2024-07-29 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 17:15 [PATCH] Hexagon: fix F2_conv_* instructions for negative zero Matheus Tavares Bernardino
2024-07-29 1:06 ` Brian Cain
2024-07-29 18:51 ` ltaylorsimpson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03df01dae1e8$49f42410$dddc6c30$@gmail.com' \
--to=ltaylorsimpson@gmail.com \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=sidneym@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).