From: Laurent Vivier <lvivier@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>,
Eric Blake <eblake@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8
Date: Mon, 26 Sep 2016 16:50:16 +0200 [thread overview]
Message-ID: <03f73e32-0c68-7bf5-f73e-73a2a90e5a01@redhat.com> (raw)
In-Reply-To: <1474899464-14849-1-git-send-email-felipe@nutanix.com>
On 26/09/2016 16:17, Felipe Franciosi wrote:
> A typo introduced in f19661c8 prevents qemu from building when configured
> with --enable-trace-backend=dtrace.
>
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/scsi/spapr_vscsi.c | 2 +-
> hw/scsi/trace-events | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> index d8a2296..6090a20 100644
> --- a/hw/scsi/spapr_vscsi.c
> +++ b/hw/scsi/spapr_vscsi.c
> @@ -658,7 +658,7 @@ static void vscsi_process_login(VSCSIState *s, vscsi_req *req)
> struct srp_login_rsp *rsp = &iu->srp.login_rsp;
> uint64_t tag = iu->srp.rsp.tag;
>
> - trace_spapr_vscsi__process_login();
> + trace_spapr_vscsi_process_login();
>
> /* TODO handle case that requested size is wrong and
> * buffer format is wrong
> diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events
> index d1995b8..4a2e5d6 100644
> --- a/hw/scsi/trace-events
> +++ b/hw/scsi/trace-events
> @@ -225,7 +225,7 @@ spapr_vscsi_command_complete_sense_data2(unsigned s8, unsigned s9, unsigned s10,
> spapr_vscsi_command_complete_status(uint32_t status) "Command complete err=%"PRIu32
> spapr_vscsi_save_request(uint32_t qtag, unsigned desc, unsigned offset) "saving tag=%"PRIu32", current desc#%u, offset=0x%x"
> spapr_vscsi_load_request(uint32_t qtag, unsigned desc, unsigned offset) "restoring tag=%"PRIu32", current desc#%u, offset=0x%x"
> -spapr_vscsi__process_login(void) "Got login, sending response !"
> +spapr_vscsi_process_login(void) "Got login, sending response !"
> spapr_vscsi_queue_cmd_no_drive(uint64_t lun) "Command for lun %08" PRIx64 " with no drive"
> spapr_vscsi_queue_cmd(uint32_t qtag, unsigned cdb, const char *cmd, int lun, int ret) "Queued command tag 0x%"PRIx32" CMD 0x%x=%s LUN %d ret: %d"
> spapr_vscsi_do_crq(unsigned c0, unsigned c1) "crq: %02x %02x ..."
>
next prev parent reply other threads:[~2016-09-26 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 14:17 [Qemu-devel] [PATCH] spapr_vscsi: fix build error introduced by f19661c8 Felipe Franciosi
2016-09-26 14:50 ` Laurent Vivier [this message]
2016-09-27 2:39 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03f73e32-0c68-7bf5-f73e-73a2a90e5a01@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=felipe@nutanix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).